Mesa (master): v3d: add missing unlock() in error path

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Jun 13 00:58:17 UTC 2020


Module: Mesa
Branch: master
Commit: 6456f71f765ce5139970445ae71172462c268a33
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6456f71f765ce5139970445ae71172462c268a33

Author: Eric Engestrom <eric at engestrom.ch>
Date:   Fri May 29 20:19:22 2020 +0200

v3d: add missing unlock() in error path

CoverityID: 1435701
Fixes: e5a81ac70431502bc592 ("broadcom/vc5: Don't forget to get the BO offset when opening a dmabuf.")
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5263>

---

 src/gallium/drivers/v3d/v3d_bufmgr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/v3d/v3d_bufmgr.c b/src/gallium/drivers/v3d/v3d_bufmgr.c
index 31a08036b38..dd8a2e98611 100644
--- a/src/gallium/drivers/v3d/v3d_bufmgr.c
+++ b/src/gallium/drivers/v3d/v3d_bufmgr.c
@@ -367,7 +367,8 @@ v3d_bo_open_handle(struct v3d_screen *screen,
                         strerror(errno));
                 free(bo->map);
                 free(bo);
-                return NULL;
+                bo = NULL;
+                goto done;
         }
         bo->offset = get.offset;
         assert(bo->offset != 0);



More information about the mesa-commit mailing list