Mesa (master): aco: fix validation of opsel when set for the definition
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Jun 17 15:57:32 UTC 2020
Module: Mesa
Branch: master
Commit: abfe28a6bb637237b3a6873eda8b09cfe4faf1e2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=abfe28a6bb637237b3a6873eda8b09cfe4faf1e2
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Jun 17 14:50:10 2020 +0100
aco: fix validation of opsel when set for the definition
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5521>
---
src/amd/compiler/aco_validate.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/amd/compiler/aco_validate.cpp b/src/amd/compiler/aco_validate.cpp
index 90272433f85..b7c773ca8f6 100644
--- a/src/amd/compiler/aco_validate.cpp
+++ b/src/amd/compiler/aco_validate.cpp
@@ -159,11 +159,11 @@ void validate(Program* program, FILE * output)
if (instr->isVOP3()) {
VOP3A_instruction *vop3 = static_cast<VOP3A_instruction*>(instr.get());
check(vop3->opsel == 0 || program->chip_class >= GFX9, "Opsel is only supported on GFX9+", instr.get());
- check((vop3->opsel & ~(0x10 | ((1 << instr->operands.size()) - 1))) == 0, "Unused bits in opsel must be zeroed out", instr.get());
- for (unsigned i = 0; i < instr->operands.size(); i++) {
- if (instr->operands[i].hasRegClass() && instr->operands[i].regClass().is_subdword() && !instr->operands[i].isFixed())
- check((vop3->opsel & (1 << i)) == 0, "Unexpected opsel for sub-dword operand", instr.get());
+ for (unsigned i = 0; i < 3; i++) {
+ if (i >= instr->operands.size() ||
+ (instr->operands[i].hasRegClass() && instr->operands[i].regClass().is_subdword() && !instr->operands[i].isFixed()))
+ check((vop3->opsel & (1 << i)) == 0, "Unexpected opsel for operand", instr.get());
}
if (instr->definitions[0].regClass().is_subdword() && !instr->definitions[0].isFixed())
check((vop3->opsel & (1 << 3)) == 0, "Unexpected opsel for sub-dword definition", instr.get());
More information about the mesa-commit
mailing list