Mesa (master): spirv: drop some dead code

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 18 03:59:22 UTC 2020


Module: Mesa
Branch: master
Commit: f94ba1555d4acfd84bbd460c54b6762ee303750a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f94ba1555d4acfd84bbd460c54b6762ee303750a

Author: Rob Clark <robdclark at chromium.org>
Date:   Tue Jun 16 11:23:26 2020 -0700

spirv: drop some dead code

This case is never hit, we don't have a nir intrinsic for this spirv
opcode.  And when we do, I'm not sure if it would be vectorized or not.
So best just to drop this case.

Signed-off-by: Rob Clark <robdclark at chromium.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5505>

---

 src/compiler/spirv/spirv_to_nir.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index 6fac715136c..7565590fbd8 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -3116,7 +3116,6 @@ vtn_handle_atomics(struct vtn_builder *b, SpvOp opcode,
    /* uniform as "atomic counter uniform" */
    if (ptr->mode == vtn_variable_mode_uniform) {
       nir_deref_instr *deref = vtn_pointer_to_deref(b, ptr);
-      const struct glsl_type *deref_type = deref->type;
       nir_intrinsic_op op = get_uniform_nir_atomic_op(b, opcode);
       atomic = nir_intrinsic_instr_create(b->nb.shader, op);
       atomic->src[0] = nir_src_for_ssa(&deref->dest.ssa);
@@ -3127,11 +3126,6 @@ vtn_handle_atomics(struct vtn_builder *b, SpvOp opcode,
        */
 
       switch (opcode) {
-      case SpvOpAtomicStore:
-         atomic->num_components = glsl_get_vector_elements(deref_type);
-         nir_intrinsic_set_write_mask(atomic, (1 << atomic->num_components) - 1);
-         break;
-
       case SpvOpAtomicLoad:
       case SpvOpAtomicExchange:
       case SpvOpAtomicCompareExchange:



More information about the mesa-commit mailing list