Mesa (master): nir: Support sysval tess levels in SPIR-V to NIR
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jun 22 14:58:15 UTC 2020
Module: Mesa
Branch: master
Commit: d2d4677b56efa0003065b61e39c1ef977c83f7da
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d2d4677b56efa0003065b61e39c1ef977c83f7da
Author: Brian Ho <brian at brkho.com>
Date: Thu May 14 11:51:43 2020 -0700
nir: Support sysval tess levels in SPIR-V to NIR
This commit adds a tess_levels_are_sysvals flag to
spirv_to_nir_options similar to GLSLTessLevelsAsInputs in the GLSL to
NIR compiler options. This will be used by turnip as the tess IR3
lowering pass (ir3_nir_lower_tess) operates on TessLevelInner and
TessLevelOuter in the DS as sysvals.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5059>
---
src/compiler/spirv/nir_spirv.h | 5 +++++
src/compiler/spirv/vtn_variables.c | 16 ++++++++++++++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/nir_spirv.h b/src/compiler/spirv/nir_spirv.h
index 3d6f74e43ca..acfcc084f41 100644
--- a/src/compiler/spirv/nir_spirv.h
+++ b/src/compiler/spirv/nir_spirv.h
@@ -64,6 +64,11 @@ struct spirv_to_nir_options {
*/
bool frag_coord_is_sysval;
+ /* Whether to lower TessLevelInner and TessLevelOuter to system values.
+ * This is the inverse of GLSLTessLevelsAsInputs in GLSL.
+ */
+ bool tess_levels_are_sysvals;
+
struct spirv_supported_capabilities caps;
/* Address format for various kinds of pointers. */
diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c
index afe2aa89bbf..b36edbafa12 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -1354,10 +1354,22 @@ vtn_get_builtin_location(struct vtn_builder *b,
vtn_fail("invalid stage for SpvBuiltInViewportIndex");
break;
case SpvBuiltInTessLevelOuter:
- *location = VARYING_SLOT_TESS_LEVEL_OUTER;
+ if (b->options && b->options->tess_levels_are_sysvals &&
+ *mode == nir_var_shader_in) {
+ *location = SYSTEM_VALUE_TESS_LEVEL_OUTER;
+ set_mode_system_value(b, mode);
+ } else {
+ *location = VARYING_SLOT_TESS_LEVEL_OUTER;
+ }
break;
case SpvBuiltInTessLevelInner:
- *location = VARYING_SLOT_TESS_LEVEL_INNER;
+ if (b->options && b->options->tess_levels_are_sysvals &&
+ *mode == nir_var_shader_in) {
+ *location = SYSTEM_VALUE_TESS_LEVEL_INNER;
+ set_mode_system_value(b, mode);
+ } else {
+ *location = VARYING_SLOT_TESS_LEVEL_INNER;
+ }
break;
case SpvBuiltInTessCoord:
*location = SYSTEM_VALUE_TESS_COORD;
More information about the mesa-commit
mailing list