Mesa (master): radv: fix checking the return value of cs_finalize()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 24 14:08:52 UTC 2020


Module: Mesa
Branch: master
Commit: 91a82d006966d5e98feceebd962873b851a6ced1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=91a82d006966d5e98feceebd962873b851a6ced1

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jun 24 15:38:19 2020 +0200

radv: fix checking the return value of cs_finalize()

cs_finalize() now returns a Vulkan error code and VK_SUCCESS is 0.

Fixes: 64a92ef7a26 ("radv/winsys: Distinguish device/host memory errors.")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5629>

---

 src/amd/vulkan/radv_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index d16235f7ce1..534fd5fd47a 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -4197,7 +4197,7 @@ radv_get_preamble_cs(struct radv_queue *queue,
 					       RADV_CMD_FLAG_START_PIPELINE_STATS, 0);
 		}
 
-		if (!queue->device->ws->cs_finalize(cs))
+		if (queue->device->ws->cs_finalize(cs) != VK_SUCCESS)
 			goto fail;
 	}
 



More information about the mesa-commit mailing list