Mesa (master): ci: Don't call renderdoc's ReplayController.Shutdown()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 25 18:12:38 UTC 2020


Module: Mesa
Branch: master
Commit: a04672a105239b230b0e880d63cee6621a10f10c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a04672a105239b230b0e880d63cee6621a10f10c

Author: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Date:   Tue Apr 14 15:57:08 2020 +0200

ci: Don't call renderdoc's ReplayController.Shutdown()

If we do, Renderdoc will call eglDestroyContext twice, causing crashes
within Mesa.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5433>

---

 .gitlab-ci/tracie/renderdoc_dump_images.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitlab-ci/tracie/renderdoc_dump_images.py b/.gitlab-ci/tracie/renderdoc_dump_images.py
index 93e24b9ca25..a89b5fda794 100755
--- a/.gitlab-ci/tracie/renderdoc_dump_images.py
+++ b/.gitlab-ci/tracie/renderdoc_dump_images.py
@@ -112,7 +112,6 @@ def renderdoc_dump_images(filename, eventIds, outputDir):
    for eventId in eventIds:
       dumpImage(controller, eventId, outputDir, tracefile)
 
-   controller.Shutdown()
    cap.Shutdown()
 
    rd.ShutdownReplay()



More information about the mesa-commit mailing list