Mesa (master): freedreno: Rename append_bo() in case it doesn't get inlined.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri May 8 20:07:28 UTC 2020


Module: Mesa
Branch: master
Commit: b3c4e6a597a45a0281cdcb8d70ec86ce8dabbb16
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3c4e6a597a45a0281cdcb8d70ec86ce8dabbb16

Author: Eric Anholt <eric at anholt.net>
Date:   Thu May  7 16:40:52 2020 -0700

freedreno: Rename append_bo() in case it doesn't get inlined.

In a debugoptimized build, it wasn't inlined and so I wasn't noticing
where a bunch of CPU usage was going in the DRM functions.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4957>

---

 src/freedreno/drm/msm_ringbuffer_sp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/freedreno/drm/msm_ringbuffer_sp.c b/src/freedreno/drm/msm_ringbuffer_sp.c
index ecb102f2535..1df82d8f599 100644
--- a/src/freedreno/drm/msm_ringbuffer_sp.c
+++ b/src/freedreno/drm/msm_ringbuffer_sp.c
@@ -116,7 +116,7 @@ static struct fd_ringbuffer * msm_ringbuffer_sp_init(
 
 /* add (if needed) bo to submit and return index: */
 static uint32_t
-append_bo(struct msm_submit_sp *submit, struct fd_bo *bo, uint32_t flags)
+msm_submit_append_bo(struct msm_submit_sp *submit, struct fd_bo *bo, uint32_t flags)
 {
 	struct msm_bo *msm_bo = to_msm_bo(bo);
 	uint32_t idx;
@@ -258,7 +258,7 @@ msm_submit_sp_flush(struct fd_submit *submit, int in_fence_fd,
 
 	for (unsigned i = 0; i < primary->u.nr_cmds; i++) {
 		cmds[i].type = MSM_SUBMIT_CMD_BUF;
-		cmds[i].submit_idx = append_bo(msm_submit,
+		cmds[i].submit_idx = msm_submit_append_bo(msm_submit,
 				primary->u.cmds[i].ring_bo, FD_RELOC_READ | FD_RELOC_DUMP);
 		cmds[i].submit_offset = primary->offset;
 		cmds[i].size = primary->u.cmds[i].size;
@@ -411,7 +411,7 @@ msm_ringbuffer_sp_emit_reloc(struct fd_ringbuffer *ring,
 		struct msm_submit_sp *msm_submit =
 				to_msm_submit_sp(msm_ring->u.submit);
 
-		append_bo(msm_submit, reloc->bo, reloc->flags);
+		msm_submit_append_bo(msm_submit, reloc->bo, reloc->flags);
 
 		pipe = msm_ring->u.submit->pipe;
 	}
@@ -478,7 +478,7 @@ msm_ringbuffer_sp_emit_reloc_ring(struct fd_ringbuffer *ring,
 		struct msm_submit_sp *msm_submit = to_msm_submit_sp(msm_ring->u.submit);
 
 		for (unsigned i = 0; i < msm_target->u.nr_reloc_bos; i++) {
-			append_bo(msm_submit, msm_target->u.reloc_bos[i].bo,
+			msm_submit_append_bo(msm_submit, msm_target->u.reloc_bos[i].bo,
 					msm_target->u.reloc_bos[i].flags);
 		}
 	}



More information about the mesa-commit mailing list