Mesa (master): pan/mdg: Use analysis to set .cont/.last flags
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue May 12 22:54:14 UTC 2020
Module: Mesa
Branch: master
Commit: 344dd914972f9ddcef814a3cf08f832708c33146
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=344dd914972f9ddcef814a3cf08f832708c33146
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Tue May 12 13:34:52 2020 -0400
pan/mdg: Use analysis to set .cont/.last flags
Corresponds roughly to what we analyze. Note that "terminate AND
execute" is a contradiction (rather: it's equivalent to just
terminating), hence why there are only three possibilities for the
states of the flags:
.cont = continue, don't execute
.last = don't continue, don't execute
.cont.last = continue and execute
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5014>
---
src/panfrost/midgard/midgard_emit.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/panfrost/midgard/midgard_emit.c b/src/panfrost/midgard/midgard_emit.c
index 98844169fae..b62052b1317 100644
--- a/src/panfrost/midgard/midgard_emit.c
+++ b/src/panfrost/midgard/midgard_emit.c
@@ -508,16 +508,8 @@ emit_binary_bundle(compiler_context *ctx,
ctx->texture_op_count--;
if (mir_op_computes_derivatives(ctx->stage, ins->texture.op)) {
- bool continues = ctx->texture_op_count > 0;
-
- /* Control flow complicates helper invocation
- * lifespans, so for now just keep helper threads
- * around indefinitely with loops. TODO: Proper
- * analysis */
- continues |= ctx->loop_count > 0;
-
- ins->texture.cont = continues;
- ins->texture.last = !continues;
+ ins->texture.cont = !ins->helper_terminate;
+ ins->texture.last = ins->helper_terminate || ins->helper_execute;
} else {
ins->texture.cont = ins->texture.last = 1;
}
More information about the mesa-commit
mailing list