Mesa (master): anv:gpu_memcpy: Emit 3DSTATE_VF_INDEXING on Gen8+

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon May 18 21:53:41 UTC 2020


Module: Mesa
Branch: master
Commit: 164aed6c8142a995c6ac1c36ee7a16896f675163
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=164aed6c8142a995c6ac1c36ee7a16896f675163

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Fri Apr 24 12:27:21 2020 -0500

anv:gpu_memcpy: Emit 3DSTATE_VF_INDEXING on Gen8+

If this gets run right after something which uses
VK_VERTEX_INPUT_RATE_INSTANCE on its first vertex binding, we could end
up in serious trouble.

Fixes: 3d9747780b "anv: Add a helper for doing buffer copies with..."

Reviewed-by: Rafael Antognolli <rafael.antognolli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5090>

---

 src/intel/vulkan/genX_gpu_memcpy.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/intel/vulkan/genX_gpu_memcpy.c b/src/intel/vulkan/genX_gpu_memcpy.c
index 504c70f3ef3..57dc55ec394 100644
--- a/src/intel/vulkan/genX_gpu_memcpy.c
+++ b/src/intel/vulkan/genX_gpu_memcpy.c
@@ -112,6 +112,13 @@ genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
          .Component3Control = (bs >= 16) ? VFCOMP_STORE_SRC : VFCOMP_STORE_0,
       });
 
+#if GEN_GEN >= 8
+   anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_VF_INSTANCING), vfi) {
+      vfi.InstancingEnable = false;
+      vfi.VertexElementIndex = 0;
+   }
+#endif
+
 #if GEN_GEN >= 8
    anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_VF_SGVS), sgvs);
 #endif



More information about the mesa-commit mailing list