Mesa (master): aco: fix off-by-one error with 16-bit MTBUF opcodes on GFX10

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue May 19 17:18:30 UTC 2020


Module: Mesa
Branch: master
Commit: cc1a1da8abbc88e17fc6dec8d000436898187971
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc1a1da8abbc88e17fc6dec8d000436898187971

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri May  8 18:02:12 2020 +0200

aco: fix off-by-one error with 16-bit MTBUF opcodes on GFX10

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4966>

---

 src/amd/compiler/aco_assembler.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/compiler/aco_assembler.cpp b/src/amd/compiler/aco_assembler.cpp
index bac91c899e7..8876b5bc8f8 100644
--- a/src/amd/compiler/aco_assembler.cpp
+++ b/src/amd/compiler/aco_assembler.cpp
@@ -408,7 +408,7 @@ void emit_instruction(asm_context& ctx, std::vector<uint32_t>& out, Instruction*
       encoding |= (0xFF & instr->operands[1].physReg());
 
       if (ctx.chip_class >= GFX10) {
-         encoding |= (((opcode & 0x08) >> 4) << 21); /* MSB of 4-bit OPCODE */
+         encoding |= (((opcode & 0x08) >> 3) << 21); /* MSB of 4-bit OPCODE */
       }
 
       out.push_back(encoding);



More information about the mesa-commit mailing list