Mesa (master): llvmpipe: compute shaders work better with all the threads.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu May 21 04:27:57 UTC 2020


Module: Mesa
Branch: master
Commit: 22554e1fbc20d0f642e952fda13d8f2631a898eb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=22554e1fbc20d0f642e952fda13d8f2631a898eb

Author: Dave Airlie <airlied at redhat.com>
Date:   Thu May 21 13:38:03 2020 +1000

llvmpipe: compute shaders work better with all the threads.

I got to benchmarking some vulkan compute benchmark and wondered
why my CPUs weren't being saturated, helps if you actually wake up
all the threads in the threadpool.

Fixes: 1b24e3ba756b (llvmpipe: add compute threadpool + mutex)

Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5138>

---

 src/gallium/drivers/llvmpipe/lp_cs_tpool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_cs_tpool.c b/src/gallium/drivers/llvmpipe/lp_cs_tpool.c
index 4a23b6a2a95..ea284468512 100644
--- a/src/gallium/drivers/llvmpipe/lp_cs_tpool.c
+++ b/src/gallium/drivers/llvmpipe/lp_cs_tpool.c
@@ -137,7 +137,7 @@ lp_cs_tpool_queue_task(struct lp_cs_tpool *pool,
 
    list_addtail(&task->list, &pool->workqueue);
 
-   cnd_signal(&pool->new_work);
+   cnd_broadcast(&pool->new_work);
    mtx_unlock(&pool->m);
    return task;
 }



More information about the mesa-commit mailing list