Mesa (master): amd/addrlib: fix forgotten char -> enum conversions

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri May 22 07:24:57 UTC 2020


Module: Mesa
Branch: master
Commit: dddd91eef326dbcdaec2a7fee6fa429d1cf6542a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dddd91eef326dbcdaec2a7fee6fa429d1cf6542a

Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Wed May 20 15:26:29 2020 +0200

amd/addrlib: fix forgotten char -> enum conversions

clang warning:
  result of comparison of constant 115 with expression of type
  'const enum Dim' is always false

Fixes: e3e704c7e7e ("amd/addrlib: Use enum instead of sparse chars to identify dimensions")
Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5119>

---

 src/amd/addrlib/src/core/coord.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/addrlib/src/core/coord.cpp b/src/amd/addrlib/src/core/coord.cpp
index b46149e7f83..3cf066daa94 100644
--- a/src/amd/addrlib/src/core/coord.cpp
+++ b/src/amd/addrlib/src/core/coord.cpp
@@ -83,11 +83,11 @@ BOOL_32 Coordinate::operator<(const Coordinate& b)
     }
     else
     {
-        if (dim == 's' || b.dim == 'm')
+        if (dim == DIM_S || b.dim == DIM_M)
         {
             ret = TRUE;
         }
-        else if (b.dim == 's' || dim == 'm')
+        else if (b.dim == DIM_S || dim == DIM_M)
         {
             ret = FALSE;
         }



More information about the mesa-commit mailing list