Mesa (master): radeonsi/sdma: remove useless compare

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri May 22 07:24:57 UTC 2020


Module: Mesa
Branch: master
Commit: e75effc629fbae477284ef80bb25a9646cd32cdd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e75effc629fbae477284ef80bb25a9646cd32cdd

Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Wed May 20 15:34:12 2020 +0200

radeonsi/sdma: remove useless compare

clang warning:
   result of comparison of constant 65536 with expression of type 'uint16_t'
   (aka 'unsigned short') is always true

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5119>

---

 src/gallium/drivers/radeonsi/cik_sdma.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/cik_sdma.c b/src/gallium/drivers/radeonsi/cik_sdma.c
index de0759ea387..d9ba9ad88b8 100644
--- a/src/gallium/drivers/radeonsi/cik_sdma.c
+++ b/src/gallium/drivers/radeonsi/cik_sdma.c
@@ -160,10 +160,9 @@ static bool si_sdma_v4_copy_texture(struct si_context *sctx, struct pipe_resourc
       /* Check if everything fits into the bitfields */
       if (!(tiled_x <= (1 << 14) && tiled_y <= (1 << 14) && tiled_z <= (1 << 11) &&
             tiled_width <= (1 << 14) && tiled_height <= (1 << 14) && tiled_depth <= (1 << 11) &&
-            tiled->surface.u.gfx9.surf.epitch <= (1 << 16) && linear_x <= (1 << 14) &&
-            linear_y <= (1 << 14) && linear_z <= (1 << 11) && linear_pitch <= (1 << 14) &&
-            linear_slice_pitch <= (1 << 28) && copy_width <= (1 << 14) &&
-            copy_height <= (1 << 14) && copy_depth <= (1 << 11)))
+            linear_x <= (1 << 14) && linear_y <= (1 << 14) && linear_z <= (1 << 11) &&
+            linear_pitch <= (1 << 14) && linear_slice_pitch <= (1 << 28) &&
+            copy_width <= (1 << 14) && copy_height <= (1 << 14) && copy_depth <= (1 << 11)))
          return false;
 
       /* Check alignments */



More information about the mesa-commit mailing list