Mesa (master): panfrost: Ensure final.no_colour is initialized.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat May 23 21:13:18 UTC 2020


Module: Mesa
Branch: master
Commit: 4174a13459da6086963b4b43b4e0dcdd680da6db
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4174a13459da6086963b4b43b4e0dcdd680da6db

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri May 22 18:34:34 2020 -0700

panfrost: Ensure final.no_colour is initialized.

Fix warning reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value final. Field final.no_colour is
uninitialized.

Fixes: 3e4e849e6a96 ("panfrost: Disable tib read/write when colourmask = 0x0")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5183>

---

 src/gallium/drivers/panfrost/pan_blend_cso.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/panfrost/pan_blend_cso.c b/src/gallium/drivers/panfrost/pan_blend_cso.c
index a68a9911b57..518005c9f68 100644
--- a/src/gallium/drivers/panfrost/pan_blend_cso.c
+++ b/src/gallium/drivers/panfrost/pan_blend_cso.c
@@ -265,6 +265,7 @@ panfrost_get_blend_for_context(struct panfrost_context *ctx, unsigned rti, struc
         struct panfrost_blend_shader *shader = panfrost_get_blend_shader(ctx, blend, fmt, rti);
         final.is_shader = true;
         final.no_blending = false;
+        final.no_colour = false;
         final.shader.work_count = shader->work_count;
         final.shader.first_tag = shader->first_tag;
 



More information about the mesa-commit mailing list