Mesa (master): util/hash_table: replace fnv1a hash function with xxhash

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon May 25 19:56:39 UTC 2020


Module: Mesa
Branch: master
Commit: 387176829bcef7058ff2be8f175295e9f80008e5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=387176829bcef7058ff2be8f175295e9f80008e5

Author: Dmitriy Nester <dmitriynester at gmail.com>
Date:   Thu Feb 27 15:17:45 2020 +0200

util/hash_table: replace fnv1a hash function with xxhash

xxhash is faster than fnv1a in almost all circumstances, so we're
switching to it globally.

Signed-off-by: Dmytro Nester <dmytro.nester at globallogic.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4020>

---

 src/util/hash_table.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/util/hash_table.c b/src/util/hash_table.c
index 0b0077cc7f3..7b2b7eb0d6a 100644
--- a/src/util/hash_table.c
+++ b/src/util/hash_table.c
@@ -597,14 +597,14 @@ _mesa_hash_u32(const void *key)
 uint32_t
 _mesa_hash_string(const void *_key)
 {
-   uint32_t hash = _mesa_fnv32_1a_offset_bias;
+   uint32_t hash = 0;
    const char *key = _key;
-
-   while (*key != 0) {
-      hash = _mesa_fnv32_1a_accumulate(hash, *key);
-      key++;
-   }
-
+   size_t len = strlen(key);
+#if defined(_WIN64) || defined(__x86_64__)
+   hash = (uint32_t)XXH64(key, len, hash);
+#else
+   hash = XXH32(key, len, hash);
+#endif
    return hash;
 }
 



More information about the mesa-commit mailing list