Mesa (master): r600/sfn: Use correct setter method.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon May 25 20:46:30 UTC 2020


Module: Mesa
Branch: master
Commit: 1241f8cb4c9c6cc65106a085be81963f3505a7d5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1241f8cb4c9c6cc65106a085be81963f3505a7d5

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sun May 24 17:18:04 2020 -0700

r600/sfn: Use correct setter method.

Fix warning reported by Coverity Scan.

Useless call (USELESS_CALL)
side_effect_free: Calling v->pin_to_channel() is only useful for its
return value, which is ignored.

Fixes: 5d10e3ec6066 ("r600/nir: Pin interpolation results to channel")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5197>

---

 src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
index 35d90a87b22..bc4a0a59e65 100644
--- a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
+++ b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
@@ -149,7 +149,7 @@ void GPRVector::set_reg_i(int i, PValue reg)
 void GPRVector::pin_to_channel(int i)
 {
    auto& v = static_cast<GPRValue&>(*m_elms[i]);
-   v.pin_to_channel();
+   v.set_pin_to_channel();
 }
 
 void GPRVector::do_print(std::ostream& os) const



More information about the mesa-commit mailing list