Mesa (staging/20.1): pan/bi: Initialize struct fma_op_info member extended.

[GitLab Mirror]

Module: Mesa
Branch: staging/20.1
Commit: 1803fad3b3eb3e2c1f2d4dcf6b6683fabebfef74
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1803fad3b3eb3e2c1f2d4dcf6b6683fabebfef74

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Tue May 26 17:26:47 2020 -0700

pan/bi: Initialize struct fma_op_info member extended.

Fix warning reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value info. Field info.extended is
uninitialized.

Fixes: 8c79c710d4e1 ("pan/bi: Identify extended FMA opcodes")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5224>
(cherry picked from commit df2c68ee4fd470efdc4f0121a2fe4aa5c64771e0)

---

 .pick_status.json                  | 2 +-
 src/panfrost/bifrost/disassemble.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 7e4919eea5a..3681a4789c3 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -211,7 +211,7 @@
         "description": "pan/bi: Initialize struct fma_op_info member extended.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "8c79c710d4e1f3e424d5abf1f9abccdfc9a59caa"
     },
diff --git a/src/panfrost/bifrost/disassemble.c b/src/panfrost/bifrost/disassemble.c
index 6205128ee6e..3657ccc4032 100644
--- a/src/panfrost/bifrost/disassemble.c
+++ b/src/panfrost/bifrost/disassemble.c
@@ -613,6 +613,7 @@ static struct fma_op_info find_fma_op_info(unsigned op, bool extended)
 
         struct fma_op_info info;
         snprintf(info.name, sizeof(info.name), "op%04x", op);
+        info.extended = extended;
         info.op = op;
         info.src_type = FMA_THREE_SRC;
         return info;