Mesa (master): st/nir: Drop setting interp mode on system values in builtins.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Nov 4 18:16:06 UTC 2020


Module: Mesa
Branch: master
Commit: 61ce544d070c58fe9823a06ba10319104074e1b5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=61ce544d070c58fe9823a06ba10319104074e1b5

Author: Eric Anholt <eric at anholt.net>
Date:   Mon Oct 26 12:16:14 2020 -0700

st/nir: Drop setting interp mode on system values in builtins.

It's initialized to INTERP_MODE_NONE on creation, which makes more sense
for sysvals than FLAT, and is also the interp mode that GLSL IR sets up
for sysvals.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7320>

---

 src/mesa/state_tracker/st_nir_builtins.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_nir_builtins.c b/src/mesa/state_tracker/st_nir_builtins.c
index 3791ce628d2..b71edc6629a 100644
--- a/src/mesa/state_tracker/st_nir_builtins.c
+++ b/src/mesa/state_tracker/st_nir_builtins.c
@@ -128,7 +128,6 @@ st_nir_make_passthrough_shader(struct st_context *st,
          snprintf(var_name, sizeof(var_name), "sys_%u", input_locations[i]);
          in = nir_variable_create(b.shader, nir_var_system_value,
                                   glsl_int_type(), var_name);
-         in->data.interpolation = INTERP_MODE_FLAT;
       } else {
          snprintf(var_name, sizeof(var_name), "in_%u", input_locations[i]);
          in = nir_variable_create(b.shader, nir_var_shader_in, vec4, var_name);



More information about the mesa-commit mailing list