Mesa (master): ci: Re-enable the clip_three test on non-freedreno ARMs.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Nov 11 17:41:18 UTC 2020


Module: Mesa
Branch: master
Commit: f6ccaca36e8961e4c96810352a5c5dfead61cc0a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f6ccaca36e8961e4c96810352a5c5dfead61cc0a

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Oct  1 15:28:38 2020 -0700

ci: Re-enable the clip_three test on non-freedreno ARMs.

I'm surprised these were listed as flaky instead of xfails, since I would
have expected them to always fail given my experience on freedreno and
broadcom.  But let's try turning them back on and see if it's actually
flaky since the test has been fixed.

Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6971>

---

 .gitlab-ci/deqp-lima-skips.txt          | 1 -
 .gitlab-ci/deqp-panfrost-g52-flakes.txt | 1 -
 .gitlab-ci/deqp-panfrost-t720-skips.txt | 3 ---
 .gitlab-ci/deqp-panfrost-t820-skips.txt | 3 ---
 .gitlab-ci/deqp-panfrost-t860-skips.txt | 3 ---
 5 files changed, 11 deletions(-)

diff --git a/.gitlab-ci/deqp-lima-skips.txt b/.gitlab-ci/deqp-lima-skips.txt
index f866ece29a6..a13f0c17c34 100644
--- a/.gitlab-ci/deqp-lima-skips.txt
+++ b/.gitlab-ci/deqp-lima-skips.txt
@@ -10,7 +10,6 @@ dEQP-GLES[0-9]*.stress
 dEQP-GLES[0-9]*.functional.flush_finish
 
 # Flaky
-dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_neg_x_neg_z_and_pos_x_pos_z_and_neg_x_neg_y_pos_z
 dEQP-GLES2.functional.default_vertex_attrib.*
 dEQP-GLES2.functional.fbo.completeness.size.distinct
 dEQP-GLES2.functional.negative_api.shader.uniform_matrixfv_invalid_transpose
diff --git a/.gitlab-ci/deqp-panfrost-g52-flakes.txt b/.gitlab-ci/deqp-panfrost-g52-flakes.txt
index 650b700c738..3b6dd214914 100644
--- a/.gitlab-ci/deqp-panfrost-g52-flakes.txt
+++ b/.gitlab-ci/deqp-panfrost-g52-flakes.txt
@@ -1,4 +1,3 @@
-dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_neg_x_neg_z_and_pos_x_pos_z_and_neg_x_neg_y_pos_z
 dEQP-GLES2.functional.texture.vertex.cube.filtering.nearest_mipmap_linear_linear_clamp
 dEQP-GLES2.functional.texture.vertex.cube.filtering.nearest_mipmap_linear_linear_mirror
 dEQP-GLES2.functional.texture.vertex.cube.filtering.nearest_mipmap_linear_linear_repeat
diff --git a/.gitlab-ci/deqp-panfrost-t720-skips.txt b/.gitlab-ci/deqp-panfrost-t720-skips.txt
index dba017e9875..e2b55048c98 100644
--- a/.gitlab-ci/deqp-panfrost-t720-skips.txt
+++ b/.gitlab-ci/deqp-panfrost-t720-skips.txt
@@ -9,9 +9,6 @@ dEQP-GLES[0-9]*.stress.*
 # These are really slow on tiling architectures (including llvmpipe).
 dEQP-GLES[0-9]*.functional.flush_finish.*
 
-# XXX: Why does this flake?
-dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_neg_x_neg_z_and_pos_x_pos_z_and_neg_x_neg_y_pos_z
-
 # Needs investigation
 dEQP-GLES2.functional.fbo.render.shared_colorbuffer.rbo_rgb565_depth_component16
 dEQP-GLES2.functional.fbo.render.shared_colorbuffer.tex2d_rgba_depth_component16
diff --git a/.gitlab-ci/deqp-panfrost-t820-skips.txt b/.gitlab-ci/deqp-panfrost-t820-skips.txt
index 0314b22c0cc..f7d0cd59a90 100644
--- a/.gitlab-ci/deqp-panfrost-t820-skips.txt
+++ b/.gitlab-ci/deqp-panfrost-t820-skips.txt
@@ -8,6 +8,3 @@ dEQP-GLES[0-9]*.stress.*
 
 # These are really slow on tiling architectures (including llvmpipe).
 dEQP-GLES[0-9]*.functional.flush_finish.*
-
-# XXX: Why does this flake?
-dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_neg_x_neg_z_and_pos_x_pos_z_and_neg_x_neg_y_pos_z
diff --git a/.gitlab-ci/deqp-panfrost-t860-skips.txt b/.gitlab-ci/deqp-panfrost-t860-skips.txt
index 0314b22c0cc..f7d0cd59a90 100644
--- a/.gitlab-ci/deqp-panfrost-t860-skips.txt
+++ b/.gitlab-ci/deqp-panfrost-t860-skips.txt
@@ -8,6 +8,3 @@ dEQP-GLES[0-9]*.stress.*
 
 # These are really slow on tiling architectures (including llvmpipe).
 dEQP-GLES[0-9]*.functional.flush_finish.*
-
-# XXX: Why does this flake?
-dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_neg_x_neg_z_and_pos_x_pos_z_and_neg_x_neg_y_pos_z



More information about the mesa-commit mailing list