Mesa (staging/20.3): 23 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Nov 13 18:58:22 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=004b8b105ff4f423fd6e03c77e7e02a84bf9d0fb
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:45:30 2020 +0100
aco: disallow various v_add_u32 opts if modifiers are used
Check for clamp, SDWA or DPP. The optimization isn't possible with SDWA
and DPP, so it would have been skipped anyway. Doing any of these with a
clamp modifier present would be incorrect.
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit 966732e8cae21ff7f5385cb776845acc3f6821ff)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46ab4f917102fadcf3f843d1c7b926e8de8be36d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:40:45 2020 +0100
aco: fix combine_constant_comparison_ordering() NaN check with 16/64-bit
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit 91ffeed88a4eccfb92bd1cc4a5a3169129128432)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=afe279ad861b080cfcf591e65cb76eed78912a93
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:09:16 2020 +0100
aco: don't combine precise max(min()) to med3
fossil-db (Navi):
Totals from 241 (0.18% of 137413) affected shaders:
CodeSize: 856280 -> 856308 (+0.00%); split: -0.00%, +0.00%
Instrs: 164220 -> 164514 (+0.18%); split: -0.00%, +0.18%
Cycles: 1031916 -> 1033092 (+0.11%); split: -0.00%, +0.11%
VMEM: 77855 -> 78514 (+0.85%); split: +0.85%, -0.01%
SMEM: 20501 -> 20593 (+0.45%); split: +0.46%, -0.01%
Copies: 9791 -> 9790 (-0.01%); split: -0.03%, +0.02%
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit d4c821da0e5924c6604b63dc923b3e8541e1f3aa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cdb5bcc0598e4c97ecb5e0056578095329fb797f
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sun Nov 8 15:59:55 2020 -0800
turnip: Fix file descriptor return.
Fix defect reported by Coverity Scan.
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach the expression -1 inside this statement: return ret ? -1 : handle.fd;
Fixes: cec0bc73e55 ("turnip: rework fences to use syncobjs")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Jonathan Marek <jonathan at marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7498>
(cherry picked from commit dad6b625768f2b68e1ea5c31da4e0e1415ef41bb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0724abde7a333bf62c59c930d7b340da8ca145d5
Author: Eric Anholt <eric at anholt.net>
Date: Wed Nov 11 11:03:57 2020 -0800
gallium/draw: Fix rasterizer_discard for wide points/lines.
Fixes the rasterizer_discard failures for softpipe, because the wide paths
(which we hit for points in the CTS) were dropping the discard state when
making the no_cull shadow state.
Cc: mesa-stable
Reviewed-by: Brian Paul <brianp at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7558>
(cherry picked from commit 0b4825c872558b1e21f6b9c6e8256482988ee243)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e3bb4aa9136e9c45ca1c36c9566171406d6c1d0
Author: Brendan Dougherty <brandougherty1 at gmail.com>
Date: Wed Nov 11 11:26:39 2020 -0600
mesa: Fix vertex_format_to_pipe_format index.
Corrects the index into the vertex_formats table for `integer` and
`normalized` values other than 0 or 1.
Fixes: e6448f993b1 ("mesa: translate into gallium vertex formats in mesa/main")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7554>
(cherry picked from commit 9edb6e1be0f8ac65496e1f0da6c78376d81d70ff)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7762b3cda4c062291c47103967b51ce579dc8db1
Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date: Tue Nov 10 17:32:15 2020 +0100
nir: handle float atomics in copy propagation pass
Without this patch, copy propagation pass can optimize out
buffer loads out of compare & swap loop, which then leads
to infinite loop.
Triggered by a change to atomicCompSwap float test in piglit.
Fixes: 8424cd8fbd1 ("nir: Account for atomics in copy propagation.")
Suggested-by: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7538>
(cherry picked from commit 6e6dab479907fe79ed24e69be841dd3ec7bd479e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe8c524c826dc1014e51671d04cc609335095887
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Nov 10 10:13:53 2020 -0600
intel/fs: Fix use of undefined value in fixup_nomask_control_flow
Fixes: a8ac0bd759cbf "intel/fs/gen12: Workaround unwanted SEND execution..."
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7536>
(cherry picked from commit e9caba6ce54d35870ef2fc555d00e2ccb45e40c0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51d4d91f7d2584674f54a25917fbb253063e19e6
Author: Eric Anholt <eric at anholt.net>
Date: Mon Nov 9 15:06:38 2020 -0800
ci: Only install kernel modules for LAVA devices.
The recent change to install kernel modules for AMD included a sed job to
disable kernel modules in the defconfig. This somehow broke booting on
a307, except the commit failed to bump the arm64_test tag so it wasn't
noticed until the next uprev. (I didn't notice when landing the next
change to that container to add the deqp runner, because I didn't get a
git conflict on rebasing my tag bump so I didn't bump the tag again to
pull in the kernel changes and catch the fail).
I've spent a while trying to debug what's happened (including what
*should* be a replication of the kernel build on my local db410c) and come
up empty. Just punt and disable the AMD kernel module changes on
baremetal to fix it. Bump every container using lava_build.sh to make
sure we don't screw anything up with the script changes.
Fixes: 60c5729d1669 ("ci: Distribute ADMGPU driver to LAVA as a module")
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6971>
(cherry picked from commit bf576b449e1d5cf685bfb5a14b05d1ee03d32cb0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a442fc2955ee2411d7d827324b44cc612efd2597
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Nov 9 16:49:44 2020 +1000
llvmpipe: just use draw_regions in draw/line setup.
This fixes:
dEQP-VK.draw.scissor*
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit d186766c08867d5447e32c427ff092612bd4ba92)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc3e92a1df137710f7d258d534a478f38533e428
Author: Dave Airlie <airlied at redhat.com>
Date: Thu Nov 5 13:18:57 2020 +1000
lavapipe: disable SNORM blending for now
dEQP-VK.pipeline.blend.dual_source.format.r16g16b16a16_snorm.states.color_1msc_1ms1a_add_alpha_1mdc_1msa_sub-color_dc_1ms1c_rsub_alpha_z_1mdc_sub-color_ca_1ms1c_min_alpha_sas_ca_rsub-color_1ms1c_s1c_add_alpha_z_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8_snorm.states.color_z_sc_add_alpha_1ms1c_sa_min-color_dc_1mca_add_alpha_z_1mca_max-color_1ms1c_sa_max_alpha_1mcc_sc_sub-color_s1c_1mda_add_alpha_s1c_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8b8a8_snorm.states.color_1msc_1ms1a_add_alpha_1mdc_1msa_sub-color_dc_1ms1c_rsub_alpha_z_1mdc_sub-color_ca_1ms1c_min_alpha_sas_ca_rsub-color_1ms1c_s1c_add_alpha_z_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8b8a8_snorm.states.color_z_sc_add_alpha_1ms1c_sa_min-color_dc_1mca_add_alpha_z_1mca_max-color_1ms1c_sa_max_alpha_1mcc_sc_sub-color_s1c_1mda_add_alpha_s1c_1mda_add,Fail
dEQP-VK.pipeline.blend.format.r16g16b16a16_snorm.states.color_ca_1mca_rsub_alpha_1mda_z_sub-color_sc_sc_add_alpha_1mca_sa_max-color_sa_1msa_min_alpha_1msc_sa_sub-color_dc_sc_add_alpha_1mdc_1mca_add,Fail
dEQP-VK.pipeline.blend.format.r8g8b8a8_snorm.states.color_ca_1mca_rsub_alpha_1mda_z_sub-color_sc_sc_add_alpha_1mca_sa_max-color_sa_1msa_min_alpha_1msc_sa_sub-color_dc_sc_add_alpha_1mdc_1mca_add,Fail
All fail due to the 1 - mdc or 1 - mca alpha channel in the last quadrant.
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit 01c4bac36e767dc96aef87fa7445a34c7c8f9132)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e4e0a0d09adc4e31cde547c17b97227aa9997da
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Nov 4 08:59:53 2020 +1000
lavapipe: enable alpha to one.
CTS seems fine with this.
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit a04a146560717014937d9e13ad24eb33cb6f0a44)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ee324d4ec1da3638f4b6791426760b87fff99ba
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Nov 9 11:06:27 2020 +1000
u_blitter: port radv 3D blit coords logic.
The current code fails a lot of VK CTS tests, this fixes them all:
dEQP-VK*blit_image*3d*
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit ea034c981b9649c4999e3b7f4164f27213e736b3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4de4f552289af8219c35a9b9a772e14c90ee88ca
Author: Dave Airlie <airlied at redhat.com>
Date: Thu Nov 5 05:42:34 2020 +1000
gallium: handle empty cbuf slots in framebuffer samples helper
If we have cbufs but they are all empty, default
to returning the fb->samples.
Fixes:
dEQP-VK.pipeline.multisample.mixed_count.1_4_unused
on lavapipe
v2:
drop unneeded chunk (Roland)
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit 4b1d23b24343dbb4e6c579502c712d86ba07903f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f4d976d5917980542acff50caa0981c20c50fc78
Author: Eric Anholt <eric at anholt.net>
Date: Tue Oct 20 14:37:10 2020 -0700
util/set: Fix the _mesa_set_clear function to not leave tombstones.
This implementation was broken and should have just been the same as the
hash_table_clear() one, which I copied over here. It was setting all
formerly-present entries to deleted, yet also setting deleted_entries to
0. This meant that all new searches or additions after clearing would
have to reprobe the whole table until a rehash happened, and that rehash
would be delayed because we violated the deleted_entries invariant.
No statistically significant performance difference on softpipe
KHR-GL33.texture_swizzle.functional runtime (n=18)
Fixes: 5c075b085585 ("util/set: add a set_clear function")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7244>
(cherry picked from commit 2afdd94f86149295f3e9422672c4501092f671d6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=966b55c6daec2a318fe0776405a3f8174ce43c64
Author: Rob Clark <robdclark at chromium.org>
Date: Mon Nov 9 14:11:09 2020 -0800
freedreno: Protect gmem_cache ralloc allocations
Since the ralloc context for cache_key allocation is shared between all
the contexts hanging off a screen, we need to allocate the key under the
screen->lock.
Fixes: 91f9bb99c5e ("freedreno: add gmem state cache")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7342>
(cherry picked from commit cb034ae44f4a1f3ed036ba71fc42746efb4cd775)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=60ffcfe6a98db7a1b3e1e3f6a001234e9a0ab071
Author: Marek Olšák <marek.olsak at amd.com>
Date: Mon Nov 9 16:20:13 2020 -0500
st/mesa: fix use-after-free when updating shader info in st_link_nir
Fixes: 549ae5f8 "st/mesa: make sure prog->info is up to date for NIR (v2)"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3756
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3685
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7516>
(cherry picked from commit 0d007349f910970ac14b20415fe76a84fd0f8fd5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46c08b73dea5c12f8fd7e3f2a404daf110d5df43
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Tue Nov 10 09:38:45 2020 +0100
softpipe: correct signature of get_compiler_options
This gets rid of a harmless but annoying compiler warning on MSVC.
Fixes: 73bafb5ee38 ("gallium: s/unsigned/enum pipe_shader_type/ for get_compiler_options()")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7524>
(cherry picked from commit 7a1346b26a70a9d6000f4889ab4d594a6a445d6d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=23f4120491d44f96cb605a577edc9824702516c1
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Tue Nov 10 11:01:50 2020 +0100
panfrost: Fix ->reads_frag_coord assignment
Let's assign ->reads_frag_coord only once to handle the sysval case
(used on Bifrost) correctly.
Fixes: f1de952b695b ("panfrost: Use shader_info harder")
Cc: 20.3 <mesa-stable>
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit f23574af2c65b9c0342656cb543bcb025cb38d9f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3ff1265ba79f6c8d1f39b3c8678578d0677913d
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Tue Nov 10 09:57:24 2020 +0100
panfrost: Fix Bifrost blend descriptor emission
Format conversion only works if the num_comps field is set to 4,
probably because the tile buffer always store those 4 components
internally.
Fixes: edd98aac3f16 ("panfrost: Add support for native wallpapering on Bifrost")
Fixes: 8389976b7c09 ("panfrost: XML-ify the blend descriptors")
Cc: 20.3 <mesa-stable>
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit 35ae9408f2a6b2f6f307562e8adc33af95406f12)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5c167e8d923a167ccb4d02ba7d9445410220edc7
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Mon Nov 9 13:44:07 2020 -0500
pan/bi: Model writemasks correctly
We don't handle partial write masks in the backend yet, so for now we
can't pretend we do, else we'll have RA bugs. Fixes
dEQP-GLES2.functional.fragment_ops.blend.rgb_func_alpha_func.src.constant_color_dst_alpha
Fixes: b2c6cf2b6db1 ("pan/bi: Eliminate writemasks in the IR")
Cc: 20.3 <mesa-stable>
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reported-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Tested-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit 7737ca75391d5ea930390037178a277d309a83af)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2940fb13eba338d14475b4af3463124abd4d9d52
Author: Icecream95 <ixn at disroot.org>
Date: Mon Nov 2 20:32:18 2020 +1300
panfrost: Fix AFBC blits of resources with faked RGTC
Because u_transfer_helper changes resources back from the real format
to the emulated format after creation, we need to fix the format enum
for resources with fake compression when doing blits to/from AFBC.
Fixes: acb8dcfebdd ("panfrost: Choose AFBC when available")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7400>
(cherry picked from commit 44f2de5286c646f9da1fc26af3780e44184aad3c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5634699a2c054cd127963eee4635f024545ebeea
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Nov 13 10:05:29 2020 -0800
.pick_status.json: Update to bf5cea7232f9ee2934c212211ebefb6fe766526d
More information about the mesa-commit
mailing list