Mesa (master): aco: remove v_{add,sub,subrev}_u32 on GFX8

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 2f5b3ac2f85dbbcc25ac3709560aa5db3ed24193
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2f5b3ac2f85dbbcc25ac3709560aa5db3ed24193

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Nov 12 12:13:36 2020 +0100

aco: remove v_{add,sub,subrev}_u32 on GFX8

These opcodes are never used and they always write the carry-out
according to the GCN3 ISA documentation.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7569>

---

 src/amd/compiler/aco_opcodes.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/amd/compiler/aco_opcodes.py b/src/amd/compiler/aco_opcodes.py
index 868ba2ba02c..95fa9c94606 100644
--- a/src/amd/compiler/aco_opcodes.py
+++ b/src/amd/compiler/aco_opcodes.py
@@ -704,9 +704,9 @@ VOP2 = {
    (  -1,   -1, 0x31, 0x31,   -1, "v_min_u16", False),
    (  -1,   -1, 0x32, 0x32,   -1, "v_min_i16", False),
    (  -1,   -1, 0x33, 0x33, 0x3b, "v_ldexp_f16", False),
-   (  -1,   -1, 0x34, 0x34, 0x25, "v_add_u32", False), # v_add_nc_u32 in RDNA
-   (  -1,   -1, 0x35, 0x35, 0x26, "v_sub_u32", False), # v_sub_nc_u32 in RDNA
-   (  -1,   -1, 0x36, 0x36, 0x27, "v_subrev_u32", False), # v_subrev_nc_u32 in RDNA
+   (  -1,   -1,   -1, 0x34, 0x25, "v_add_u32", False), # use v_add_co_u32 on GFX8, called v_add_nc_u32 in RDNA
+   (  -1,   -1,   -1, 0x35, 0x26, "v_sub_u32", False), # use v_sub_co_u32 on GFX8, called v_sub_nc_u32 in RDNA
+   (  -1,   -1,   -1, 0x36, 0x27, "v_subrev_u32", False), # use v_subrev_co_u32 on GFX8, called v_subrev_nc_u32 in RDNA
    (  -1,   -1,   -1,   -1, 0x36, "v_fmac_f16", False),
    (  -1,   -1,   -1,   -1, 0x37, "v_fmamk_f16", False),
    (  -1,   -1,   -1,   -1, 0x38, "v_fmaak_f16", False),