Mesa (staging/20.2): amd/addrlib: Add missing va_end.

[GitLab Mirror]

Module: Mesa
Branch: staging/20.2
Commit: 21943f650cb888cfdc94c0d10b5c503d2b44a4c2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=21943f650cb888cfdc94c0d10b5c503d2b44a4c2

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri Oct 23 17:32:16 2020 -0700

amd/addrlib: Add missing va_end.

Fix defect reported by Coverity Scan.

Missing varargs init or cleanup (VARARGS)
missing_va_end: va_end was not called for debugPrintInput.ap.

Fixes: 69ea473eeb91 ("amd/addrlib: update to the latest version")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7299>
(cherry picked from commit c8630fd1143f055249a35877aa056878e56d00c3)

---

 .pick_status.json                       | 2 +-
 src/amd/addrlib/src/core/addrobject.cpp | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 3479403b52b..5ff665fe9b9 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -3919,7 +3919,7 @@
         "description": "amd/addrlib: Add missing va_end.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "69ea473eeb91b2c4db26402c3bc2ed5799d26605"
     },
diff --git a/src/amd/addrlib/src/core/addrobject.cpp b/src/amd/addrlib/src/core/addrobject.cpp
index d148d2f5646..339be4e702a 100644
--- a/src/amd/addrlib/src/core/addrobject.cpp
+++ b/src/amd/addrlib/src/core/addrobject.cpp
@@ -230,6 +230,7 @@ VOID Object::DebugPrint(
         m_client.callbacks.debugPrint(&debugPrintInput);
 
         va_end(ap);
+        va_end(debugPrintInput.ap);
     }
 #endif
 }