Mesa (master): nv50/ir: Initialize GCRA members in constructor.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Nov 18 03:21:40 UTC 2020


Module: Mesa
Branch: master
Commit: edc63ad44c73e55a67f3ea86746513e035ddd347
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=edc63ad44c73e55a67f3ea86746513e035ddd347

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Nov  9 19:48:04 2020 -0800

nv50/ir: Initialize GCRA members in constructor.

Fix defect reported by Coverity Scan.

Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member nodes is not initialized in this
constructor nor in any functions that it calls.
uninit_member: Non-static class member nodeCount is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7522>

---

 src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
index 6a6ba044041..8977c5f65b3 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
@@ -1210,6 +1210,8 @@ GCRA::RIG_Node::addRegPreference(RIG_Node *node)
 }
 
 GCRA::GCRA(Function *fn, SpillCodeInserter& spill, MergedDefs& mergedDefs) :
+   nodes(NULL),
+   nodeCount(0),
    func(fn),
    regs(fn->getProgram()->getTarget()),
    spill(spill),



More information about the mesa-commit mailing list