Mesa (20.3): 48 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Nov 19 18:18:47 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40e3de32e13aea822713471a723ed8c8c432fda8
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Nov 19 10:12:47 2020 -0800
bump VERSION for 20.3.0-rc2 release
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0201fc95e7f9fc47687dfa412372f4e2c1a60629
Author: Matt Turner <mattst88 at gmail.com>
Date: Tue Nov 17 14:58:24 2020 -0500
glcpp: Handle bison-3.6 error message changes
In bison's commit 72c9fa4510eb (skeletons: use "end of file" instead of
"$end") in bison-3.6, '$end' was changed to 'end of file' in error
messages. Since our glcpp test cases contain the expected output text,
they rely on the particular messages printed by bison. The test case
084-unbalanced-parentheses fails when Mesa is built with bison-3.6 due
to this change.
To allow the test to pass on all supported versions of bison, we:
1. Change '$end' -> 'end of file' in the .expected file, and
2. Normalize the error generated by the test case with the same
replacement
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3181
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7659>
(cherry picked from commit df29d0a111da3a555d8f0751722ca70fe0c5ffc0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=827c0cc14f7f4a328c5ced3b5b5777b42fbf5d3a
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Nov 19 10:11:01 2020 -0800
.pick_status.json: Update to bac6cc586fe4c1b24351e0574d3a961eb631f6ae
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=654376faad6c6be108ac938801ff732fd986f6c9
Author: Chad Versace <chad at kiwitree.net>
Date: Tue Sep 8 09:44:43 2020 -0700
anv/image: Fix isl_surf_usage_flags for stencil images
Respect VkImageStencilUsageCreateInfoEXT.
CC: mesa-stable at lists.freedesktop.org
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit b50275a4b63d3da12ead2f6e57be8988223af83d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9d10b391c121e0518b9e2b124f87aa28c108970
Author: Chad Versace <chad at kiwitree.net>
Date: Tue Aug 4 10:14:11 2020 -0700
anv/image: Check DISJOINT in vkGetPhysicalDeviceImageFormatProperties2 (v2)
The code did not return error when VK_IMAGE_CREATE_DISJOINT_BIT was
incompatible with the other input params.
If the Vulkan spec forbids a set of input params for vkCreateImage,
but permits them for vkGetPhysicalDeviceImageFormatProperties2,
then vkGetPhysicalDeviceImageFormatProperties2 must reject those input
params with failure.
- v2: Clearer commit message.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com> (v2)
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 51a19c83b000407a31b5cd17b996084a6b58a4ff)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1534e28669ddaec5031027f6f98e3ae371a09a42
Author: Erik Faye-Lund <kusmabite at gmail.com>
Date: Fri Nov 13 16:53:04 2020 +0100
zink: more accurately track supported blits
We don't care if blits need to respect render-conditions if there's no
active one. So let's hit the potentially faster native blit-paths
instead.
Fixes: 5743fa6e709 ("zink: enable conditional rendering if available")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3792
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7606>
(cherry picked from commit 19906022e22cb37493861b6976c9623618b5b769)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f076b4d3ab9b56f9ee2316f6df2898d0a13ce517
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Nov 16 16:23:47 2020 -0800
turnip: Close sync_fd only if it is a valid file descriptor.
Fix defects reported by Coverity Scan.
Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: sync_fd is passed to a parameter that cannot be negative.
Fixes: cec0bc73e55 ("turnip: rework fences to use syncobjs")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7647>
(cherry picked from commit 69cad1f96ef4481cc2395def9c993ddcbb0e2540)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f6a73228a47915e703afcc1e13b8a9b752504c36
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Nov 9 17:31:36 2020 -0800
clover/spirv: Add missing break for SpvOpExecutionMode case.
Fix defect reported by Coverity Scan.
Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value SpvOpExecutionMode is not
terminated by a 'break' statement.
Fixes: ee5b46fcfdb ("clover/spirv: support CL_KERNEL_COMPILE_WORK_GROUP_SIZE")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7519>
(cherry picked from commit 71ee4e2853bc4af270969e6d91533cba7b9c0cb4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5953d04aec1704fd28cb006282685cc8d34ddecc
Author: Vinson Lee <vlee at freedesktop.org>
Date: Wed Oct 28 19:47:42 2020 -0700
frontends/va: Fix *num_entrypoints check.
Fix defect reported by Coverity Scan.
Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking num_entrypoints suggests that it
may be null, but it has already been dereferenced on all paths
leading to the check.
Fixes: 5bcaa1b9e970 ("st/va: add encode entrypoint v2")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7360>
(cherry picked from commit 7820c8c13ff3e9367b208f09059c940a1629f708)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94f202c6bc5371ccdc21b96dc5a2afb076fd64a6
Author: Eric Anholt <eric at anholt.net>
Date: Mon Aug 3 19:23:34 2020 -0700
freedreno: Fix leak of shader binary on disk cache hits.
It's supposed to be ralloced -- there's not even a shader variant destroy
function for freeing, just ralloc_free() on the ir3_shader_variant or the
parent ir3_shader when you're done!
Fixes: f97acb4bb4b1 ("freedreno/ir3: disk-cache support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5810>
(cherry picked from commit 433841d9eb7cd9dd5e00b2f47cd998e0e986ef02)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7366262d2b4e341c09a1b7b15e2c1d72424c03e
Author: Lucas Stach <l.stach at pengutronix.de>
Date: Mon Nov 16 14:58:38 2020 +0100
etnaviv: fix disabling of INT filter for real
Missing a copy of the pipe_sampler_state into the etna_sampler_state object
lead to the texture_use_int_filter() to always see a max_anisotropy of 0, so
the INT filter wasn't disabled when necessary. Also state emission should
never change the state objects, as this might also lead to stale information
being kept around the in the state object.
Fixes: 89a41dae7702 (etnaviv: do not use int filter when
anisotropic filtering is used)
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7638>
(cherry picked from commit b479a1f03cdcf70b86df6903ace6ff8c92f205b9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce29a107f438247aab2df9f38af74286408c1630
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Nov 16 12:33:36 2020 +0100
mesa/main: add missing include in glformats.h
This header uses uint32_t without including stdint.h. This worked fine
by accident until a new c-source started including it.
Fixes: 1bf539b3a21 ("mesa: Clamp some depth values in glClearBufferfv")
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7637>
(cherry picked from commit 2410def98fa688aa009b42de3224e12e5ddbaff3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9d399939e0842b756652c825d211ce1349029492
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Nov 13 15:12:21 2020 +0000
aco: fix fp16 *0.5 omod
We were testing for -0.5 instead.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Fixes: 1210e0bd620 ("aco: create 16-bit input and output modifiers")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7605>
(cherry picked from commit 0c522d3aa7432b72c2ed773218d6f0eb25f58943)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc0580d3441152336134d4840a7b70389bd67cd5
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Nov 13 15:10:58 2020 +0000
aco: disable omod if the sign of zeros should be preserved
The RDNA ISA doc says that omod doesn't preserve -0.0 in 6.2.2. LLVM
appears to always disable omod in this situation, but clamp is unaffected.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Fixes: df645fa369d ("aco: implement VK_KHR_shader_float_controls")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7605>
(cherry picked from commit 558daa73f9adb1275ddcf00515c7f79f726b7ae1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ded5cd528a9567fce68909a60c19dbd6b65c1211
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Wed Nov 11 08:59:46 2020 +0200
iris: initialize shared screen->vtbl only once
Screen is shared among contexts, other context might be already using
vtbl while another initializes it again.
==45872== Possible data race during write of size 8 at 0x5DDAE78 by thread #549
==45872== Locks held: 1, at address 0x5D1B6F8
==45872== at 0x6D66D91: gen9_init_state (iris_state.c:7816)
==45872== by 0x6BA0A31: iris_create_context (iris_context.c:342)
==45872== by 0x621F390: st_api_create_context (st_manager.c:917)
==45872== by 0x620E6F9: dri_create_context (dri_context.c:163)
==45872== by 0x6A40DB1: driCreateContextAttribs (dri_util.c:480)
==45872== by 0x540B963: dri2_create_context (egl_dri2.c:1583)
==45872== by 0x53FB84E: eglCreateContext (eglapi.c:821)
==45872==
==45872== This conflicts with a previous read of size 8 by thread #544
==45872== Locks held: 1, at address 0x5F6E0E0
==45872== at 0x6CB779E: blorp_alloc_binding_table (iris_blorp.c:167)
==45872== by 0x6CAEF70: blorp_emit_surface_states (blorp_genX_exec.h:1540)
==45872== by 0x6CB67F9: blorp_exec (blorp_genX_exec.h:2016)
==45872== by 0x6CB7AFE: iris_blorp_exec (iris_blorp.c:307)
==45872== by 0x70F5916: try_blorp_blit (blorp_blit.c:2145)
==45872== by 0x70F5FCA: do_blorp_blit (blorp_blit.c:2273)
==45872== by 0x70F778F: blorp_copy (blorp_blit.c:2803)
==45872== by 0x6BB9EB6: iris_copy_region (iris_blit.c:725)
v2: move as genX(init_screen_state) (Lionel)
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7544>
(cherry picked from commit 460287adcadf1c03b13fccd397fcd9d270c4d31d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=15367d29693891a809ddae5baee686b16b0bfa3e
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 10 15:52:00 2020 +0200
egl/dri2: fix race between image create and egl_image_target_texture
All other functions calling _eglLookupImage hold the display lock.
==16659== Possible data race during write of size 8 at 0x5D1BCF0 by thread #2668
==16659== Locks held: 1, at address 0x5D1B6F8
==16659== at 0x5405DDF: _eglLinkResource (egldisplay.c:454)
==16659== by 0x53F9189: _eglLinkImage (eglimage.h:138)
==16659== by 0x53FE2CA: _eglCreateImageCommon (eglapi.c:1740)
==16659== by 0x53FE39A: eglCreateImageKHR (eglapi.c:1751)
==16659==
==16659== This conflicts with a previous read of size 8 by thread #2664
==16659== Locks held: 1, at address 0x5308D00
==16659== at 0x5405C06: _eglCheckResource (egldisplay.c:387)
==16659== by 0x5408C92: _eglLookupImage (eglimage.h:162)
==16659== by 0x5409E96: dri2_lookup_egl_image (egl_dri2.c:688)
==16659== by 0x6210AAF: dri2_lookup_egl_image (dri_helpers.c:250)
==16659== by 0x6212843: dri_get_egl_image (dri_screen.c:470)
==16659== by 0x625F7CC: st_get_egl_image (st_cb_eglimage.c:152)
==16659== by 0x625FE7D: st_egl_image_target_texture_2d (st_cb_eglimage.c:354)
==16659== by 0x6501C05: egl_image_target_texture (teximage.c:3446)
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7544>
(cherry picked from commit 959c2d1edbf56934f6d313a48136f6f1740dc549)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee3ed20f3d89332a541a9fc4b3c09cbd010e82cf
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Nov 13 17:15:53 2020 +1000
draw: fix tess eval pipeline statistics.
The number of invocations wasn't getting incremented correctly.
Fixes: 202bc38ce9e3 ("draw: collect tessellation invocations statistics")
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7597>
(cherry picked from commit ce07c52b825903e698b63bc608d7ddb8cb578cd6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5327be5acbb0fd115505a05e43b4cb0822ceace
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date: Sun Nov 15 11:56:23 2020 +0100
etnaviv: nir: do not run opt loop after nir_lower_bool_xxx(..)
Running the optimizations after bool to float/int lowering is not going
to work. Large portions of NIR are likely to blow up if they see
floats/ints in weird places. Most of the bool->float/int conversions
are direct instruction substitutions and it's not going to leave a lot
of garbage around to optimize.
Fixes nir.h:261: nir_const_value_as_bool: Assertion `i == 0 || i == -1' failed
dEQP-GLES2.functional.shaders.loops.while_constant_iterations.no_iterations_vertex
Here are shader-db results for GC2000:
instructions HURT: shaders/tesseract/488.shader_test FRAG: 516 -> 524 (1.55%)
instructions HURT: shaders/tesseract/491.shader_test FRAG: 248 -> 260 (4.84%)
instructions HURT: shaders/tesseract/494.shader_test FRAG: 244 -> 256 (4.92%)
instructions HURT: shaders/tesseract/238.shader_test FRAG: 232 -> 244 (5.17%)
instructions HURT: shaders/tesseract/241.shader_test FRAG: 232 -> 244 (5.17%)
instructions HURT: shaders/tesseract/127.shader_test FRAG: 76 -> 80 (5.26%)
instructions HURT: shaders/tesseract/130.shader_test FRAG: 148 -> 156 (5.41%)
instructions HURT: shaders/tesseract/226.shader_test FRAG: 192 -> 204 (6.25%)
instructions HURT: shaders/tesseract/229.shader_test FRAG: 192 -> 204 (6.25%)
instructions HURT: shaders/tesseract/217.shader_test FRAG: 152 -> 164 (7.89%)
instructions HURT: shaders/tesseract/214.shader_test FRAG: 152 -> 164 (7.89%)
instructions HURT: shaders/tesseract/205.shader_test FRAG: 112 -> 124 (10.71%)
instructions HURT: shaders/tesseract/202.shader_test FRAG: 112 -> 124 (10.71%)
instructions HURT: shaders/tesseract/169.shader_test FRAG: 32 -> 36 (12.50%)
instructions HURT: shaders/tesseract/166.shader_test FRAG: 32 -> 36 (12.50%)
instructions HURT: shaders/deqp_gles3/61312.shader_test FRAG: 448 -> 508 (13.39%)
instructions HURT: shaders/deqp_gles3/61309.shader_test FRAG: 448 -> 508 (13.39%)
instructions HURT: shaders/deqp_gles3/61324.shader_test FRAG: 448 -> 508 (13.39%)
instructions HURT: shaders/tesseract/118.shader_test FRAG: 28 -> 32 (14.29%)
instructions HURT: shaders/tesseract/181.shader_test FRAG: 52 -> 60 (15.38%)
instructions HURT: shaders/tesseract/178.shader_test FRAG: 52 -> 60 (15.38%)
instructions HURT: shaders/tesseract/121.shader_test FRAG: 52 -> 60 (15.38%)
instructions HURT: shaders/tesseract/193.shader_test FRAG: 72 -> 84 (16.67%)
instructions HURT: shaders/tesseract/190.shader_test FRAG: 72 -> 84 (16.67%)
total instructions in shared programs: 64220 -> 64572 (0.55%)
instructions in affected programs: 4924 -> 5276 (7.15%)
helped: 5
HURT: 24
helped stats (abs) min: 4 max: 8 x̄: 5.60 x̃: 4
helped stats (rel) min: 4.35% max: 5.41% x̄: 4.72% x̃: 4.35%
HURT stats (abs) min: 4 max: 60 x̄: 15.83 x̃: 12
HURT stats (rel) min: 1.55% max: 16.67% x̄: 10.04% x̃: 10.71%
95% mean confidence interval for instructions value: 5.39 18.89
95% mean confidence interval for instructions %-change: 4.81% 10.18%
Instructions are HURT.
total temps in shared programs: 2514 -> 2512 (-0.08%)
temps in affected programs: 9 -> 7 (-22.22%)
helped: 2
HURT: 0
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7624>
(cherry picked from commit 9b6516ac249ee479b78e399e1a54a293e53e9676)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8ddfc0bb78b8e295a2278a0b7196acce287391b
Author: Vinson Lee <vlee at freedesktop.org>
Date: Fri Oct 16 15:41:12 2020 -0700
vdpau: Add missing printf format specifier.
Fix defect reported by Coverity Scan.
Extra argument to printf format specifier (PRINTF_ARGS)
extra_argument: This argument was not used by the format string: vmixer->max_layers.
Fixes: 89b986325227 ("vdpau: Add support for parameters")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Leo Liu <leo.liu at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7200>
(cherry picked from commit 3fe5c13d71b831b42798755a3ba983b5de6d1563)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=159ded94814ee78496e87897d1f774e317c20613
Author: Rob Clark <robdclark at chromium.org>
Date: Thu Nov 12 12:39:28 2020 -0800
freedreno/ir3: Fix crash in shader compile fail path
Fixes: 74140c2e859 ("freedreno/ir3: convert over to ralloc")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7612>
(cherry picked from commit 4b65c09d86d37efa34e93b17b0e4a03546f26af9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4de41dea583c14dd306749a74942685183fe60d9
Author: Icecream95 <ixn at disroot.org>
Date: Sat Nov 14 00:12:26 2020 +1300
panfrost: Fix stack shift calculation
Fixes flickering in Neverwinter Nights.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3789
Fixes: e6152091ca9 ("panfrost: Use canonical characterization of tls_size")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7613>
(cherry picked from commit 12dec2004ed0b50b0cb0ad7cc635f2a706be9891)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b37d613da5b0393f1a2ba34dd5baea9916dd0b9b
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Fri Nov 6 10:55:03 2020 -0800
mesa: Clamp some depth values in glClearBufferfi
OpenGL 3.0 spec, section 4.2.3 "Clearing the Buffers":
depth and stencil are the values to clear the depth and stencil
buffers to, respectively. Clamping and type conversion for
fixed-point depth buffers are performed in the same fashion as for
ClearDepth.
Enables iris to pass the clearbuffer-depth-stencil piglit test.
Cc: mesa-stable
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit 2e713313a29422b38435c91f8277c1893fcad095)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d47cb4124ac9d515bd91fa3c1e807ac1c05bda35
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Mon Nov 2 09:02:42 2020 -0800
mesa: Clamp some depth values in glClearBufferfv
OpenGL 3.0 spec, section 4.2.3 "Clearing the Buffers":
If buffer is DEPTH, drawbuffer must be zero, and value points to the
single depth value to clear the depth buffer to. Clamping and type
conversion for fixed-point depth buffers are performed in the same
fashion as for ClearDepth.
Enables iris to pass the clearbuffer-depth piglit test.
v2. Add spec citation. (Eric Anholt)
v3. Don't clamp floating point formats. (Eric Anholt)
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit 1bf539b3a2129779addde397886870c00045e6d7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b83eb0b0980a5f488ef4bab589f8537960f7072
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Thu Nov 5 15:45:44 2020 -0800
mesa: Add and use _mesa_has_depth_float_channel
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit fda015023af5d0d2d844d5fde07a8c19e4d8f453)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=14167715ccc8619fcc75dce0ad4681aebeab9cd6
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Nov 17 10:55:38 2020 -0800
.pick_status.json: Update to 87dc3106b077199b829a082e32ec33d0c6d400ab
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=004b8b105ff4f423fd6e03c77e7e02a84bf9d0fb
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:45:30 2020 +0100
aco: disallow various v_add_u32 opts if modifiers are used
Check for clamp, SDWA or DPP. The optimization isn't possible with SDWA
and DPP, so it would have been skipped anyway. Doing any of these with a
clamp modifier present would be incorrect.
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit 966732e8cae21ff7f5385cb776845acc3f6821ff)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46ab4f917102fadcf3f843d1c7b926e8de8be36d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:40:45 2020 +0100
aco: fix combine_constant_comparison_ordering() NaN check with 16/64-bit
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit 91ffeed88a4eccfb92bd1cc4a5a3169129128432)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=afe279ad861b080cfcf591e65cb76eed78912a93
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Oct 7 11:09:16 2020 +0100
aco: don't combine precise max(min()) to med3
fossil-db (Navi):
Totals from 241 (0.18% of 137413) affected shaders:
CodeSize: 856280 -> 856308 (+0.00%); split: -0.00%, +0.00%
Instrs: 164220 -> 164514 (+0.18%); split: -0.00%, +0.18%
Cycles: 1031916 -> 1033092 (+0.11%); split: -0.00%, +0.11%
VMEM: 77855 -> 78514 (+0.85%); split: +0.85%, -0.01%
SMEM: 20501 -> 20593 (+0.45%); split: +0.46%, -0.01%
Copies: 9791 -> 9790 (-0.01%); split: -0.03%, +0.02%
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7045>
(cherry picked from commit d4c821da0e5924c6604b63dc923b3e8541e1f3aa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cdb5bcc0598e4c97ecb5e0056578095329fb797f
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sun Nov 8 15:59:55 2020 -0800
turnip: Fix file descriptor return.
Fix defect reported by Coverity Scan.
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach the expression -1 inside this statement: return ret ? -1 : handle.fd;
Fixes: cec0bc73e55 ("turnip: rework fences to use syncobjs")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Jonathan Marek <jonathan at marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7498>
(cherry picked from commit dad6b625768f2b68e1ea5c31da4e0e1415ef41bb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0724abde7a333bf62c59c930d7b340da8ca145d5
Author: Eric Anholt <eric at anholt.net>
Date: Wed Nov 11 11:03:57 2020 -0800
gallium/draw: Fix rasterizer_discard for wide points/lines.
Fixes the rasterizer_discard failures for softpipe, because the wide paths
(which we hit for points in the CTS) were dropping the discard state when
making the no_cull shadow state.
Cc: mesa-stable
Reviewed-by: Brian Paul <brianp at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7558>
(cherry picked from commit 0b4825c872558b1e21f6b9c6e8256482988ee243)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e3bb4aa9136e9c45ca1c36c9566171406d6c1d0
Author: Brendan Dougherty <brandougherty1 at gmail.com>
Date: Wed Nov 11 11:26:39 2020 -0600
mesa: Fix vertex_format_to_pipe_format index.
Corrects the index into the vertex_formats table for `integer` and
`normalized` values other than 0 or 1.
Fixes: e6448f993b1 ("mesa: translate into gallium vertex formats in mesa/main")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7554>
(cherry picked from commit 9edb6e1be0f8ac65496e1f0da6c78376d81d70ff)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7762b3cda4c062291c47103967b51ce579dc8db1
Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date: Tue Nov 10 17:32:15 2020 +0100
nir: handle float atomics in copy propagation pass
Without this patch, copy propagation pass can optimize out
buffer loads out of compare & swap loop, which then leads
to infinite loop.
Triggered by a change to atomicCompSwap float test in piglit.
Fixes: 8424cd8fbd1 ("nir: Account for atomics in copy propagation.")
Suggested-by: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7538>
(cherry picked from commit 6e6dab479907fe79ed24e69be841dd3ec7bd479e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe8c524c826dc1014e51671d04cc609335095887
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Nov 10 10:13:53 2020 -0600
intel/fs: Fix use of undefined value in fixup_nomask_control_flow
Fixes: a8ac0bd759cbf "intel/fs/gen12: Workaround unwanted SEND execution..."
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7536>
(cherry picked from commit e9caba6ce54d35870ef2fc555d00e2ccb45e40c0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51d4d91f7d2584674f54a25917fbb253063e19e6
Author: Eric Anholt <eric at anholt.net>
Date: Mon Nov 9 15:06:38 2020 -0800
ci: Only install kernel modules for LAVA devices.
The recent change to install kernel modules for AMD included a sed job to
disable kernel modules in the defconfig. This somehow broke booting on
a307, except the commit failed to bump the arm64_test tag so it wasn't
noticed until the next uprev. (I didn't notice when landing the next
change to that container to add the deqp runner, because I didn't get a
git conflict on rebasing my tag bump so I didn't bump the tag again to
pull in the kernel changes and catch the fail).
I've spent a while trying to debug what's happened (including what
*should* be a replication of the kernel build on my local db410c) and come
up empty. Just punt and disable the AMD kernel module changes on
baremetal to fix it. Bump every container using lava_build.sh to make
sure we don't screw anything up with the script changes.
Fixes: 60c5729d1669 ("ci: Distribute ADMGPU driver to LAVA as a module")
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6971>
(cherry picked from commit bf576b449e1d5cf685bfb5a14b05d1ee03d32cb0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a442fc2955ee2411d7d827324b44cc612efd2597
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Nov 9 16:49:44 2020 +1000
llvmpipe: just use draw_regions in draw/line setup.
This fixes:
dEQP-VK.draw.scissor*
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit d186766c08867d5447e32c427ff092612bd4ba92)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc3e92a1df137710f7d258d534a478f38533e428
Author: Dave Airlie <airlied at redhat.com>
Date: Thu Nov 5 13:18:57 2020 +1000
lavapipe: disable SNORM blending for now
dEQP-VK.pipeline.blend.dual_source.format.r16g16b16a16_snorm.states.color_1msc_1ms1a_add_alpha_1mdc_1msa_sub-color_dc_1ms1c_rsub_alpha_z_1mdc_sub-color_ca_1ms1c_min_alpha_sas_ca_rsub-color_1ms1c_s1c_add_alpha_z_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8_snorm.states.color_z_sc_add_alpha_1ms1c_sa_min-color_dc_1mca_add_alpha_z_1mca_max-color_1ms1c_sa_max_alpha_1mcc_sc_sub-color_s1c_1mda_add_alpha_s1c_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8b8a8_snorm.states.color_1msc_1ms1a_add_alpha_1mdc_1msa_sub-color_dc_1ms1c_rsub_alpha_z_1mdc_sub-color_ca_1ms1c_min_alpha_sas_ca_rsub-color_1ms1c_s1c_add_alpha_z_1mda_add,Fail
dEQP-VK.pipeline.blend.dual_source.format.r8g8b8a8_snorm.states.color_z_sc_add_alpha_1ms1c_sa_min-color_dc_1mca_add_alpha_z_1mca_max-color_1ms1c_sa_max_alpha_1mcc_sc_sub-color_s1c_1mda_add_alpha_s1c_1mda_add,Fail
dEQP-VK.pipeline.blend.format.r16g16b16a16_snorm.states.color_ca_1mca_rsub_alpha_1mda_z_sub-color_sc_sc_add_alpha_1mca_sa_max-color_sa_1msa_min_alpha_1msc_sa_sub-color_dc_sc_add_alpha_1mdc_1mca_add,Fail
dEQP-VK.pipeline.blend.format.r8g8b8a8_snorm.states.color_ca_1mca_rsub_alpha_1mda_z_sub-color_sc_sc_add_alpha_1mca_sa_max-color_sa_1msa_min_alpha_1msc_sa_sub-color_dc_sc_add_alpha_1mdc_1mca_add,Fail
All fail due to the 1 - mdc or 1 - mca alpha channel in the last quadrant.
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit 01c4bac36e767dc96aef87fa7445a34c7c8f9132)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e4e0a0d09adc4e31cde547c17b97227aa9997da
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Nov 4 08:59:53 2020 +1000
lavapipe: enable alpha to one.
CTS seems fine with this.
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit a04a146560717014937d9e13ad24eb33cb6f0a44)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ee324d4ec1da3638f4b6791426760b87fff99ba
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Nov 9 11:06:27 2020 +1000
u_blitter: port radv 3D blit coords logic.
The current code fails a lot of VK CTS tests, this fixes them all:
dEQP-VK*blit_image*3d*
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit ea034c981b9649c4999e3b7f4164f27213e736b3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4de4f552289af8219c35a9b9a772e14c90ee88ca
Author: Dave Airlie <airlied at redhat.com>
Date: Thu Nov 5 05:42:34 2020 +1000
gallium: handle empty cbuf slots in framebuffer samples helper
If we have cbufs but they are all empty, default
to returning the fb->samples.
Fixes:
dEQP-VK.pipeline.multisample.mixed_count.1_4_unused
on lavapipe
v2:
drop unneeded chunk (Roland)
Cc: 20.3 <mesa-stable>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7499>
(cherry picked from commit 4b1d23b24343dbb4e6c579502c712d86ba07903f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f4d976d5917980542acff50caa0981c20c50fc78
Author: Eric Anholt <eric at anholt.net>
Date: Tue Oct 20 14:37:10 2020 -0700
util/set: Fix the _mesa_set_clear function to not leave tombstones.
This implementation was broken and should have just been the same as the
hash_table_clear() one, which I copied over here. It was setting all
formerly-present entries to deleted, yet also setting deleted_entries to
0. This meant that all new searches or additions after clearing would
have to reprobe the whole table until a rehash happened, and that rehash
would be delayed because we violated the deleted_entries invariant.
No statistically significant performance difference on softpipe
KHR-GL33.texture_swizzle.functional runtime (n=18)
Fixes: 5c075b085585 ("util/set: add a set_clear function")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7244>
(cherry picked from commit 2afdd94f86149295f3e9422672c4501092f671d6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=966b55c6daec2a318fe0776405a3f8174ce43c64
Author: Rob Clark <robdclark at chromium.org>
Date: Mon Nov 9 14:11:09 2020 -0800
freedreno: Protect gmem_cache ralloc allocations
Since the ralloc context for cache_key allocation is shared between all
the contexts hanging off a screen, we need to allocate the key under the
screen->lock.
Fixes: 91f9bb99c5e ("freedreno: add gmem state cache")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7342>
(cherry picked from commit cb034ae44f4a1f3ed036ba71fc42746efb4cd775)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=60ffcfe6a98db7a1b3e1e3f6a001234e9a0ab071
Author: Marek Olšák <marek.olsak at amd.com>
Date: Mon Nov 9 16:20:13 2020 -0500
st/mesa: fix use-after-free when updating shader info in st_link_nir
Fixes: 549ae5f8 "st/mesa: make sure prog->info is up to date for NIR (v2)"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3756
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3685
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7516>
(cherry picked from commit 0d007349f910970ac14b20415fe76a84fd0f8fd5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46c08b73dea5c12f8fd7e3f2a404daf110d5df43
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Tue Nov 10 09:38:45 2020 +0100
softpipe: correct signature of get_compiler_options
This gets rid of a harmless but annoying compiler warning on MSVC.
Fixes: 73bafb5ee38 ("gallium: s/unsigned/enum pipe_shader_type/ for get_compiler_options()")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7524>
(cherry picked from commit 7a1346b26a70a9d6000f4889ab4d594a6a445d6d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=23f4120491d44f96cb605a577edc9824702516c1
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Tue Nov 10 11:01:50 2020 +0100
panfrost: Fix ->reads_frag_coord assignment
Let's assign ->reads_frag_coord only once to handle the sysval case
(used on Bifrost) correctly.
Fixes: f1de952b695b ("panfrost: Use shader_info harder")
Cc: 20.3 <mesa-stable>
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit f23574af2c65b9c0342656cb543bcb025cb38d9f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3ff1265ba79f6c8d1f39b3c8678578d0677913d
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Tue Nov 10 09:57:24 2020 +0100
panfrost: Fix Bifrost blend descriptor emission
Format conversion only works if the num_comps field is set to 4,
probably because the tile buffer always store those 4 components
internally.
Fixes: edd98aac3f16 ("panfrost: Add support for native wallpapering on Bifrost")
Fixes: 8389976b7c09 ("panfrost: XML-ify the blend descriptors")
Cc: 20.3 <mesa-stable>
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit 35ae9408f2a6b2f6f307562e8adc33af95406f12)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5c167e8d923a167ccb4d02ba7d9445410220edc7
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Mon Nov 9 13:44:07 2020 -0500
pan/bi: Model writemasks correctly
We don't handle partial write masks in the backend yet, so for now we
can't pretend we do, else we'll have RA bugs. Fixes
dEQP-GLES2.functional.fragment_ops.blend.rgb_func_alpha_func.src.constant_color_dst_alpha
Fixes: b2c6cf2b6db1 ("pan/bi: Eliminate writemasks in the IR")
Cc: 20.3 <mesa-stable>
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reported-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Tested-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7527>
(cherry picked from commit 7737ca75391d5ea930390037178a277d309a83af)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2940fb13eba338d14475b4af3463124abd4d9d52
Author: Icecream95 <ixn at disroot.org>
Date: Mon Nov 2 20:32:18 2020 +1300
panfrost: Fix AFBC blits of resources with faked RGTC
Because u_transfer_helper changes resources back from the real format
to the emulated format after creation, we need to fix the format enum
for resources with fake compression when doing blits to/from AFBC.
Fixes: acb8dcfebdd ("panfrost: Choose AFBC when available")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7400>
(cherry picked from commit 44f2de5286c646f9da1fc26af3780e44184aad3c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5634699a2c054cd127963eee4635f024545ebeea
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Nov 13 10:05:29 2020 -0800
.pick_status.json: Update to bf5cea7232f9ee2934c212211ebefb6fe766526d
More information about the mesa-commit
mailing list