Mesa (master): radv/query: Avoid hardcoding array size constants

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 20 09:39:30 UTC 2020


Module: Mesa
Branch: master
Commit: 9eda7f475cfebe79cefdb2ab19daeaa29030c704
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9eda7f475cfebe79cefdb2ab19daeaa29030c704

Author: Tony Wasserka <tony.wasserka at gmx.de>
Date:   Tue Nov  3 17:22:06 2020 +0100

radv/query: Avoid hardcoding array size constants

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7430>

---

 src/amd/vulkan/radv_query.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 5f12f7727aa..e7cf82e39cc 100644
--- a/src/amd/vulkan/radv_query.c
+++ b/src/amd/vulkan/radv_query.c
@@ -371,7 +371,7 @@ build_pipeline_statistics_query_shader(struct radv_device *device) {
 	nir_push_if(&b, nir_i2b(&b, available32));
 
 	nir_store_var(&b, output_offset, output_base, 0x1);
-	for (int i = 0; i < 11; ++i) {
+	for (int i = 0; i < ARRAY_SIZE(pipeline_statistics_indices); ++i) {
 		nir_push_if(&b, nir_test_flag(&b, stats_mask, 1u << i));
 
 		load = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_ssbo);
@@ -1318,7 +1318,7 @@ VkResult radv_GetQueryPoolResults(
 			if (flags & VK_QUERY_RESULT_64_BIT) {
 				uint64_t *dst = (uint64_t*)dest;
 				dest += util_bitcount(pool->pipeline_stats_mask) * 8;
-				for(int i = 0; i < 11; ++i) {
+				for(int i = 0; i < ARRAY_SIZE(pipeline_statistics_indices); ++i) {
 					if(pool->pipeline_stats_mask & (1u << i)) {
 						if (available || (flags & VK_QUERY_RESULT_PARTIAL_BIT))
 							*dst = stop[pipeline_statistics_indices[i]] -
@@ -1330,7 +1330,7 @@ VkResult radv_GetQueryPoolResults(
 			} else {
 				uint32_t *dst = (uint32_t*)dest;
 				dest += util_bitcount(pool->pipeline_stats_mask) * 4;
-				for(int i = 0; i < 11; ++i) {
+				for(int i = 0; i < ARRAY_SIZE(pipeline_statistics_indices); ++i) {
 					if(pool->pipeline_stats_mask & (1u << i)) {
 						if (available || (flags & VK_QUERY_RESULT_PARTIAL_BIT))
 							*dst = stop[pipeline_statistics_indices[i]] -



More information about the mesa-commit mailing list