Mesa (master): clover: Initialize command_queue member _props.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Nov 21 02:13:51 UTC 2020


Module: Mesa
Branch: master
Commit: ba9906fc8f27aaeff1c90f3e2b125173bc3684c4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba9906fc8f27aaeff1c90f3e2b125173bc3684c4

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Thu Nov 19 17:03:18 2020 -0800

clover: Initialize command_queue member _props.

Fix defect reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value this->_props.
    _props |= properties[i + 1];

Fixes: e42a7fa0378 ("clover: add support command queue properties")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7701>

---

 src/gallium/frontends/clover/core/queue.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/frontends/clover/core/queue.cpp b/src/gallium/frontends/clover/core/queue.cpp
index b5e36e57f4a..33a760d6b0a 100644
--- a/src/gallium/frontends/clover/core/queue.cpp
+++ b/src/gallium/frontends/clover/core/queue.cpp
@@ -60,7 +60,7 @@ command_queue::command_queue(clover::context &ctx, clover::device &dev,
 }
 command_queue::command_queue(clover::context &ctx, clover::device &dev,
                              std::vector<cl_queue_properties> properties) :
-   context(ctx), device(dev), _properties(properties) {
+   context(ctx), device(dev), _properties(properties), _props(0) {
 
    for(std::vector<cl_queue_properties>::size_type i = 0; i != properties.size(); i += 2) {
       if (properties[i] == 0)



More information about the mesa-commit mailing list