Mesa (master): v3dv: fix leak in the buffer to image copy via texel buffer

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 27 06:54:41 UTC 2020


Module: Mesa
Branch: master
Commit: 2809e2e816069ae267fb429d9c0fafd75db9e58c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2809e2e816069ae267fb429d9c0fafd75db9e58c

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Thu Nov 26 08:02:36 2020 +0100

v3dv: fix leak in the buffer to image copy via texel buffer

Fixes: ba69c36ada5 ("v3dv: add a buffer to image copy path using a texel buffer")
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7782>

---

 src/broadcom/vulkan/v3dv_meta_copy.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/broadcom/vulkan/v3dv_meta_copy.c b/src/broadcom/vulkan/v3dv_meta_copy.c
index 70307bf30f6..534ae20ef09 100644
--- a/src/broadcom/vulkan/v3dv_meta_copy.c
+++ b/src/broadcom/vulkan/v3dv_meta_copy.c
@@ -3223,6 +3223,10 @@ texel_buffer_shader_copy(struct v3dv_cmd_buffer *cmd_buffer,
       if (result != VK_SUCCESS)
          goto fail;
 
+      v3dv_cmd_buffer_add_private_obj(
+         cmd_buffer, (uintptr_t)image_view,
+         (v3dv_cmd_buffer_private_obj_destroy_cb)v3dv_DestroyImageView);
+
       VkFramebufferCreateInfo fb_info = {
          .sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO,
          .renderPass = pipeline->pass,



More information about the mesa-commit mailing list