Mesa (master): v3dv: enable the logicOp feature

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Oct 27 06:58:54 UTC 2020


Module: Mesa
Branch: master
Commit: e4b170a72062e0648ca87a847975717600c20e6b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4b170a72062e0648ca87a847975717600c20e6b

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Mon Oct 26 13:00:07 2020 +0100

v3dv: enable the logicOp feature

For us this is mostly handled in the compiler by a NIR lowering so
for the Vulkan driver we only need to make sure that we program our
shader key correctly from the pipeline state, which we were already
doing.

It doesn't look like CTS has any coverage for this yet so it has only
been smoke tested, but it seems to be working correctly, as expected.

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7313>

---

 src/broadcom/vulkan/v3dv_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c
index 6e0eefb031d..501c042c167 100644
--- a/src/broadcom/vulkan/v3dv_device.c
+++ b/src/broadcom/vulkan/v3dv_device.c
@@ -676,7 +676,7 @@ v3dv_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice,
       .tessellationShader = false,
       .sampleRateShading = true,
       .dualSrcBlend = false,
-      .logicOp = false,
+      .logicOp = true,
       .multiDrawIndirect = false,
       .drawIndirectFirstInstance = false,
       .depthClamp = false,



More information about the mesa-commit mailing list