Mesa (master): nir: Improve the comment on num_inputs and friends

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Sep 1 17:44:13 UTC 2020


Module: Mesa
Branch: master
Commit: 15da98365388983eb9ef1a65c2e7da6ef2ab89e0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=15da98365388983eb9ef1a65c2e7da6ef2ab89e0

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Mon Aug 31 13:06:04 2020 -0500

nir: Improve the comment on num_inputs and friends

This doesn't fix the problem that no one knows what any of these mean
half the time but it at least makes them better documented to hopefully
make people's expectations more accurate.

Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6524>

---

 src/compiler/nir/nir.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
index 6195a66fd25..e6edb72ecf2 100644
--- a/src/compiler/nir/nir.h
+++ b/src/compiler/nir/nir.h
@@ -3322,8 +3322,9 @@ typedef struct nir_shader {
    struct exec_list functions; /** < list of nir_function */
 
    /**
-    * the highest index a load_input_*, load_uniform_*, etc. intrinsic can
-    * access plus one
+    * The size of the variable space for load_input_*, load_uniform_*, etc.
+    * intrinsics.  This is in back-end specific units which is likely one of
+    * bytes, dwords, or vec4s depending on context and back-end.
     */
    unsigned num_inputs, num_uniforms, num_outputs;
 



More information about the mesa-commit mailing list