Mesa (20.2): 50 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Sep 3 14:38:41 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b89a76b7ceef2229f8e9eca1c9f792732356a40c
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Sep 2 20:07:43 2020 -0700
VERSION: bump for 20.2.0-rc4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=525a5b763d6009383a5c794cc8cccf12f3cc7aba
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jul 17 16:22:11 2020 -0500
intel/fs: Fix MOV_INDIRECT and BROADCAST of Q types on Gen11+
The immediate case is pretty uncommon to see but it can happen, in
theory. BROADCAST is typically used to uniformize values and those are
usually 32-bit. However, it does come up in some subgroup ops.
Fixes: 49c21802cbca "intel/compiler: Split has_64bit_types into float/int"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6211>
(cherry picked from commit cccb497d3c3bbc8f615fe79d774eb42a48e5a95c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3d1a71aa2beeffea8be8e2f60d22ee01879d815f
Author: Roman Gilg <subdiff at gmail.com>
Date: Mon Aug 31 11:35:16 2020 +0200
vulkan/wsi/x11: wait for acquirable images in FIFO mode
In FIFO presentation mode we block either on our present-queue or on Present
events after an image was transmitted.
In case we receive completion events without idle events at some point we
exhaust our acquire-queue and can not block anymore on present-queue.
Ensure that the consumer has at least one image to acquire before blocking
again on present-queue. Otherwise wait for one from the X server.
CC: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3344
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Simon Ser <contact at emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6513>
(cherry picked from commit ec5e918ef4911d09b5611773bc58952b13ccef38)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6e4106024e30ed886bb542946505d0e3edb6b0b
Author: Roman Gilg <subdiff at gmail.com>
Date: Mon Aug 31 11:33:27 2020 +0200
vulkan/wsi/x11: add sent image counter
Add a counter to count how many images from our swapchain are currently "sent"
to the X server via Present extension. An image is sent when it has been
presented but we have not yet received an idle event for it.
CC: mesa-stable
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Simon Ser <contact at emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6513>
(cherry picked from commit d0bc1ad3776bce7d4b356e2a3d8bdbb9ae64e588)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd1dbd904cbe99c461641e31ee3d976e3d960dd8
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Aug 31 16:08:55 2020 +0200
nir/algebraic: mark some optimizations with fsat(NaN) as inexact
If a is Nan, fsat(NaN) is expected to be 0 and some optimizations
should be marked as inexact.
Fixes a GPU hang with Death Stranding and RADV/ACO (RADV/LLVM
isn't affected because it lowers fsat).
No fossils-db change.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3368
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6519>
(cherry picked from commit bc123c396a99b2f6ff845792374d6a8d5de5d15e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1629fe89a659a5af95cdc5e473e1eceb6413d1e1
Author: Marek Olšák <marek.olsak at amd.com>
Date: Mon Aug 31 21:59:39 2020 -0400
gallivm: fix build on LLVM 12 due to LLVMAddConstantPropagationPass removal
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3465
Cc: 20.1 20.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6531>
(cherry picked from commit 52cac068621a5998f486f8e44f9c2d9d045d1c31)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a63155052a9362964224039639af0ec88e8def4
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sun Aug 30 17:39:43 2020 -0700
vulkan: Fix memory leaks.
Fix warnings reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable info going out of scope leaks the storage it
points to.
Fixes: 9bc5b2d169d3 ("vulkan: add initial device selection layer. (v6.1)")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6509>
(cherry picked from commit 004119d5b7d4b1679e6dd691e9ab2ab7d65f8516)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=22b4120de4d0840adc66b07ff74f59d0fe6b6b69
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Mon Aug 31 14:20:59 2020 -0400
pan/mdg: Fix perspective combination
It's not enough to multiply by a .w reciprocal, we have to be taking the
reciprocal of the thing we're actually multiplying against.
Fixes incorrect rendering in Manhattan.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6525>
(cherry picked from commit 41d0a81c2a3f09701e8c694b520c8d900f6ac2f1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e57b4680d3ca5a6c56686040fcde517494a7049
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Mon Aug 31 14:04:55 2020 -0400
pan/mdg: Fix discard encoding
Let's match the blob.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6525>
(cherry picked from commit c8ac01af33a5bc63822915f08f89a7dbaf7d433f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=83dda7b35f5d807f0f61bee7cad665ba3a29a510
Author: Eric Anholt <eric at anholt.net>
Date: Thu Aug 13 15:15:26 2020 -0700
turnip: Make sure we include the build id.
The ir3 disk cache is initialized when we use the ir3 compiler, even if we
don't use it ourselves, and it requires a build id. With lld, it seems we
don't end up getting one included by default.
Fixes: f97acb4bb4b1 ("freedreno/ir3: disk-cache support")
Reviewed-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6324>
(cherry picked from commit 221aa00eeb33938dab06b26c8a770ecae3698825)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7518930a99d00cdd8e71f4eb26e350ceff17d645
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Aug 10 10:27:57 2020 +0300
anv: VK_INTEL_performance_query interaction with VK_EXT_private_data
All objects are expected to have the base internal object for private
data storage.
This also fixes a memory leak of a gen_perf_registers structure.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 51c6bc13ce3a70 ("anv,vulkan: Implement VK_EXT_private_data")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6255>
(cherry picked from commit b6a013ccab0f5545bdc2e63dae1c93e688a93eaa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=57d65d2f76f5937bc8876e5a8fc0a7f4d768f63c
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Wed Jun 24 23:27:52 2020 +1000
util/u_thread: include pthread_np.h if found
Required for pthread_set_name_np() on OpenBSD as there is no
pthread_setaffinity_np() to define PTHREAD_SETAFFINITY_IN_NP_HEADER.
Fixes: dcf9d91a80e ("util: Handle differences in pthread_setname_np")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit 55765f80b9ce7cce4ec6a1c2bed6476776d9cbed)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d37550f8e7af497488e1221ae2eecbdfafd77d27
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Thu Feb 20 13:18:01 2020 +1100
util: futex fixes for OpenBSD
Fix absolute to relative timeout computation.
Add sanity checks to futex_wait()
- handle the NULL timeout pointer case
- avoid negative cases.
From Matthieu Herrb and Scott Cheloha.
Fixes: c91997b6c43 ("util/futex: use futex syscall on OpenBSD")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Acked-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit c66c5b38e0ad136aa9301fd60aafea736d433c57)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=43bd915ff5612e8d212fa355519bb04a6d3be6ad
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Fri Dec 6 17:25:58 2019 +1100
meson: conditionally include -ldl in gbm pkg-config file
Follow libGL and only include -ldl in gbm pkg-config file if libdl was
actually found. Many systems have these functions in libc and don't
have libdl.
Fixes: 816bf7d1644 ("meson: build gbm")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit 0398caa97fa6ab9a0eac29dfca38b3fceb2cc026)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db2fa8208c8a9eefad29ed6e20cddd32d8382621
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Fri Dec 6 15:23:36 2019 +1100
meson: don't build with USE_ELF_TLS on OpenBSD
OpenBSD does not have TLS
Fixes: a47c525f328 ("meson: build glx")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit c97af23b13c55c27f5fe381793ee9a3d6f3a2280)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe8d18e75254e7d1c91578ace6a34627ff636ed9
Author: Eric Engestrom <eric.engestrom at intel.com>
Date: Thu Nov 21 22:14:50 2019 +0000
meson: don't advertise TLS support if glx wasn't build with it
Fixes: a47c525f328 ("meson: build glx")
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit 9ac16864227cc63ca6b23eeab39fdcc7f85beca5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8f4094bb1c4d178df8ca13db828c76074d42d3ce
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Fri Dec 6 14:30:14 2019 +1100
meson: build with _ISOC11_SOURCE on OpenBSD
Mesa builds with -std=c99 but uses timespec_get() a c11 function.
Build with _ISOC11_SOURCE for c11 visibility when -std is specified.
On linux c11 visibility comes from defining _GNU_SOURCE.
Fixes: e3a8013de8c ("util/u_queue: add util_queue_fence_wait_timeout")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit f9a7e6e854ddedafd3c85f7eaeca1a00ee7bced5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=372f8f5c534af0f94f753b10bb15647e8fb14de5
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Thu Nov 1 13:16:13 2018 +1100
util/anon_file: add OpenBSD shm_mkstemp() path
memfd_create() is a linux syscall replace the use of it with
shm_mkstemp() on OpenBSD.
unconditionally include stdlib.h for mkstemp()/mkostemp()
Fixes: c0376a12341 ("util: add anon_file.h for all memfd/temp file usage")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit 6e9c0661f8538cdabe7d7de73af11b4165f51f93)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3d0f9e3dc307935f7c753b5682d9bd79beae8760
Author: Jonathan Gray <jsg at jsg.id.au>
Date: Wed Mar 28 14:06:14 2018 +1100
util: unbreak endian detection on OpenBSD
Since cbee1bfb34274668a05995b9d4c78ddec9e5ea4c endian.h is unconditionally
used if available.
glibc has byte order defines with two leading underscores. OpenBSD
has private defines with a single leading underscore in machine/endian.h
and public defines in endian.h with no underscore.
The code under the endian.h block did not check if symbols were
defined before equating them so '#if __BYTE_ORDER == __LITTLE_ENDIAN'
would turn into '#if 0 == 0' which is always true.
Fixes: cbee1bfb342 ("meson/configure: detect endian.h instead of trying to guess when it's available")
Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630>
(cherry picked from commit 7eab6845e9dd49f0ef0bf9a7d986aaf685e77981)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=64039dffc4cf341d1162c0ff4c4f1b30e445f9ec
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Aug 7 11:25:54 2020 -0500
intel/nir: Rewrite the guts of lower_alpha_to_coverage
I have no idea how this pass ever worked. I guess it worked ok on the
one or two piglit tests but the whole thing seemed very fragile. It
makes a number of undocumented and unasserted assumptions and they
aren't always valid. This rewrite makes a number of changes:
1. It now properly handles the case where the gl_SampleMask write comes
before the gl_FragColor or gl_FragData[0] write.
2. It should early-exit faster because it now looks at bits in
shader_info::outputs_written instead of looking for variables.
3. Instead of the fragile variable lookup where we try to look the
variable up by both location and driver_location and match, we just
use the driver_location calculations used by brw_fs_nir.
4. It asserts that the index parameter to store_output is a constant
instead of silently failing if it isn't.
5. We now actually assert the implicit assumption that the two writes
are in the same block. We go even further and assert that they are
in the last block in the shader.
6. In the case where 3 or fewer components of the output are written,
we explicitly choose to leave the sample mask alone.
Fixes: 7ecfbd4f6d4 "nir: Add alpha_to_coverage lowering pass"
Closes: #3166
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6233>
(cherry picked from commit b6fdb1405ee2688ffc15acdf0476dece8bc8846b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=367be430b512cbca6c63944deead76805b005596
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Aug 7 11:19:45 2020 -0500
intel/nir: Pass the nir_builder by reference in lower_alpha_to_coverage
I'm honestly not sure how passing a builder by-value ever worked. I
guess the struct is mostly copyable. In any case, that's the wrong way
to use it and it's causing issues.
Fixes: 7ecfbd4f6d4 "nir: Add alpha_to_coverage lowering pass"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6233>
(cherry picked from commit 72dc06e07e3f8b9ed5bb46e3927b8f87dd24e42b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eefc95d601f3f9c4aed3e144533f04385a66cffd
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Sep 1 13:53:23 2020 -0700
.pick_status.json: Update to b9927c8c8d0c105699306a68773c015930ff9509
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb53f1937a3ff55bcf43d530d4817c3928340373
Author: Eric Engestrom <eric at engestrom.ch>
Date: Sat May 23 01:45:42 2020 +0200
egl/x11_dri3: implement EGL_KHR_swap_buffers_with_damage
Passes all of `dEQP-EGL.functional.swap_buffers_with_damage.*`:
Passed: 36/54 (66.7%)
Failed: 0/54 (0.0%)
Not supported: 18/54 (33.3%)
Warnings: 0/54 (0.0%)
Waived: 0/54 (0.0%)
The "not supported" ones are the `preserve_buffer_*` tests, which is not
supported on X11/DRI3.
Cc: 20.2 <mesa-stable>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3030
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6132>
(cherry picked from commit 326eb56718925828e886f40f72ea4a97b4657196)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=93659e4ed3d11429416337afd59611b81e131a80
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Aug 25 11:54:14 2020 -0700
iris: Drop stale syncobj references in fence_server_sync
When calling glWaitSync (fence_server_sync), we added dependencies
in all batches (render and compute) on existing work. Even if
applications don't use compute at all, they theoretically could,
so we record that the compute batch depends on the render batch.
But if the application truly doesn't use compute, or rarely uses
it, we ended up recording dependencies on _all_ previous render
batches, racking up a massive list of syncobjs. Not only is this
pointless, it also meant that we never allowed the kernel to free
the underlying i915_request objects.
There are a number of solutions to this problem, but for now, we
take a simple one: when recording a new syncobj dependency, we
walk the list and see if any of them have already passed. If so,
that dependency has been fulfilled. We no longer need to track it,
and can simply drop it from the list, unreferencing the syncobj.
Android's SurfaceFlinger in particular was hitting this issue,
as it uses glWaitSync, doesn't typically use compute shaders,
and runs for long durations.
Thanks to Yang A Shi <yang.a.shi at intel.com> and
Kefei Yao <kefei.yao at intel.com> for their excellent work in
tracking down this issue!
Fixes: f459c56be6b ("iris: Add fence support using drm_syncobj")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Tapani Pälli <tapani.palli at intel.com>
Tested-by: Yang A Shi <yang.a.shi at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6463>
(cherry picked from commit 6b1a56b908e702c06f55c63b19b695a47f607456)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a020620c25f93dbf5d2609f0393e6354674cfe0b
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Aug 25 09:47:13 2020 -0700
iris: Reorder the loops in iris_fence_await() for clarity.
Swapping the order of the loops makes the logic much easier to follow:
for each point in our fence, if it hasn't gone by, make future work in
all batches depend on it. Both loops are necessary, and now it's
clearer why.
(This doesn't actually fix a bug but needs to be cherry-picked for
the next patch to apply, which does fix a bug.)
Fixes: f459c56be6b ("iris: Add fence support using drm_syncobj")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Tapani Pälli <tapani.palli at intel.com>
Tested-by: Yang A Shi <yang.a.shi at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6463>
(cherry picked from commit e98c7a66347a05fc166c377ab1abb77955aff775)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=948a2fbec5f1cf006687800ec265b9867e228f6f
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Tue Aug 25 19:12:37 2020 +0200
radv: Fix 3d blits.
- the offsets are inclusive-exclusive so the +1 was wrong
- Since the GPU doesn't do the interpolation on depth (as we render
per layer), we have to add an offset for the pixel center.
CC: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3073
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6458>
(cherry picked from commit 4d40a719b07670b64d6ed4313818ac8d309bb77f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=17837b663779ec8490740f4c64d4e98d503b90a9
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Aug 4 16:06:56 2020 +0100
aco: create long jumps
When the branch offset can't be encoded, we have to use s_setpc_b64.
Fixes hang in RPCS3 vertex ubershader.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3231
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit fe2dc41258b1d868b59c44256ef8397f301ed7da)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9a66f08cfed7dbe2f9c424290da79ce63dede62d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Aug 4 14:18:55 2020 +0100
aco: reserve 2 sgprs for each branch
We'll need two sgprs for the possibility of a long jump.
fossil-db (Navi):
Totals from 10197 (7.50% of 135946) affected shaders:
SGPRs: 946268 -> 946468 (+0.02%)
VGPRs: 705884 -> 707956 (+0.29%); split: -0.00%, +0.30%
SpillSGPRs: 31485 -> 36212 (+15.01%); split: -0.04%, +15.05%
CodeSize: 88296484 -> 88384604 (+0.10%); split: -0.01%, +0.11%
MaxWaves: 81379 -> 81171 (-0.26%)
Instrs: 17219111 -> 17231682 (+0.07%); split: -0.03%, +0.10%
Cycles: 1594875900 -> 1596450136 (+0.10%); split: -0.05%, +0.15%
VMEM: 1687263 -> 1689080 (+0.11%); split: +0.14%, -0.03%
SMEM: 657726 -> 660262 (+0.39%); split: +0.61%, -0.22%
VClause: 294806 -> 294638 (-0.06%); split: -0.08%, +0.02%
SClause: 556702 -> 556210 (-0.09%); split: -0.12%, +0.03%
Copies: 1466323 -> 1469349 (+0.21%); split: -0.57%, +0.78%
Branches: 619793 -> 618556 (-0.20%); split: -0.28%, +0.08%
PreSGPRs: 806364 -> 811477 (+0.63%); split: -0.14%, +0.77%
PreVGPRs: 655845 -> 657174 (+0.20%)
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit 156fd58cdacb28a7fca88fc9ffc84c3cdfbbb8f3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=90ccdf42705a0f717f6f3693c5944323176baff8
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Aug 6 17:38:41 2020 +0100
aco: keep loop live-through variables spilled
fossil-db (Navi):
Totals from 3149 (2.32% of 135946) affected shaders:
VGPRs: 280928 -> 280932 (+0.00%)
SpillSGPRs: 51133 -> 30042 (-41.25%)
CodeSize: 43063076 -> 41377252 (-3.91%); split: -3.92%, +0.00%
Instrs: 8278435 -> 8037133 (-2.91%); split: -2.92%, +0.00%
Cycles: 709575456 -> 683366172 (-3.69%); split: -3.69%, +0.00%
VMEM: 542887 -> 542937 (+0.01%); split: +0.05%, -0.04%
SMEM: 210255 -> 206368 (-1.85%); split: +0.12%, -1.97%
SClause: 258847 -> 258019 (-0.32%); split: -0.52%, +0.20%
Copies: 731836 -> 684784 (-6.43%); split: -6.44%, +0.01%
Branches: 305422 -> 292844 (-4.12%); split: -4.12%, +0.00%
PreSGPRs: 333103 -> 332701 (-0.12%)
PreVGPRs: 280086 -> 280089 (+0.00%)
Helps mostly Detroit: Become Human and the single spilling Doom Eternal
shader.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit e8ac14527a2fd384c1f2cce56e44a9e93e0a13ec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed64b3d8e989ea1045b54447593265aba99fbf5d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Aug 6 15:57:05 2020 +0100
aco: fix spills_entry heuristic for branch blocks in init_live_in_vars()
fossil-db (Navi):
Totals from 222 (0.16% of 135946) affected shaders:
SpillSGPRs: 9121 -> 9117 (-0.04%)
SpillVGPRs: 2820 -> 1821 (-35.43%)
CodeSize: 5134264 -> 5053336 (-1.58%); split: -1.63%, +0.05%
Instrs: 953435 -> 938761 (-1.54%); split: -1.59%, +0.05%
Cycles: 100567688 -> 97252432 (-3.30%); split: -3.34%, +0.04%
VMEM: 40752 -> 39219 (-3.76%); split: +0.04%, -3.80%
SMEM: 15416 -> 15509 (+0.60%); split: +0.64%, -0.03%
VClause: 20120 -> 19091 (-5.11%)
SClause: 23540 -> 23544 (+0.02%); split: -0.11%, +0.12%
Copies: 125912 -> 122017 (-3.09%); split: -3.36%, +0.26%
Branches: 31131 -> 30009 (-3.60%)
Mostly affects parallel-rdp ubershaders.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit 75d6c30572ce78952f76ee62a71332a424ca886a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a024de19ac5d1d1d2e9dbc8dc20a4e38265aeda6
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Aug 25 21:19:11 2020 +0100
aco: fix regclass checks when fixing to vcc/exec with Builder
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit fc9f502a5bd853128a9c2932c793180035883efc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=643ae5ea249039b9333bee138376b0517194dba9
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Aug 26 11:10:37 2020 +0100
aco: don't fix break condition for break+discard to exec
This would move the old exec mask back into exec. This also fixes the
live_out_exec.
Issue found in dEQP-VK.graphicsfuzz.cosh-return-inf-unused
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit a537c9e73f86d8cb3f4a2b48b4143708b146f0fe)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=01c1323180a053fb4693ed285cbddb9eed3464e8
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Aug 5 13:29:58 2020 +0100
aco: don't consider the first partial spill if it's the wrong type
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit 1a5444b90013213fa1f1108dc74e17c5e596e5a0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bbc9b56a67020f0b9bdecda2b0112da0855d2de9
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Aug 4 17:08:43 2020 +0100
aco: consider branch definitions in spiller
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 20.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6212>
(cherry picked from commit 8f6a900d5e5decd54f71ca89c950548089086c14)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51c029f77a824ef5386454e83e4961f3efc0ab25
Author: Marek Vasut <marex at denx.de>
Date: Tue Jul 21 16:21:14 2020 +0200
etnaviv: Add lock around pending_ctx
The content of rsc->pending_ctx could be changed from multiple contexts
and thus from multiple threads. The per-context lock is not sufficient
to protect this list. Add per-resource lock to protect this list.
Fixes: e5cc66dfad0 ("etnaviv: Rework locking")
Signed-off-by: Marek Vasut <marex at denx.de>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6454>
(cherry picked from commit 60975ebe58ddb05beebbdd3850dc9d866aee5420)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9699e42a3c549dacd2c5c57ae3124b73e2dda500
Author: Marek Vasut <marex at denx.de>
Date: Tue Jul 21 16:21:34 2020 +0200
etnaviv: Remove etna_resource_get_status()
This function is not used, remove it.
Signed-off-by: Marek Vasut <marex at denx.de>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6454>
(cherry picked from commit da660c90bf94527c3d54a9a59e7f7df935480479)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=75462d48ec330b2698a0d65f57837226025f0e9c
Author: Alejandro Piñeiro <apinheiro at igalia.com>
Date: Mon Aug 24 10:33:46 2020 +0200
v3d: set instance id to 0 at start of tile
PTB assumes that base instance to be 0 at start of tile, but hw would
not do that, we need to set it. It is worth to note that the opcode
name is somewhat confusing as what it really sets is the base
instance. We could rename the opcode, but then the name would be
different to the original Broadcom name, so confusing in any case.
This fixes several dEQP-GLES3 and dEQP-GLES31 tests that passes
individually, but started to fail depending on other tests running
before using base instance different to zero.
This is the backport of a Vulkan patch that fixed some Vulkan CTS
tests that start to fails after some other tests used an instance id.
CC: 20.2 20.1 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6447>
(cherry picked from commit 05a0349949921406aefe1d99e9d2af84629997e1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=42f6206a841013291770b83b28e2cd6796dc3c40
Author: Alejandro Piñeiro <apinheiro at igalia.com>
Date: Thu Aug 20 01:02:53 2020 +0200
v3d/packet: fix typo on Set InstanceID/PrimitiveID packet
Fixes: 276d22c52 ("v3d: Add some more new packets for V3D 4.x.")
CC: 20.2 20.1 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6447>
(cherry picked from commit 2e8b6f64decc1bfdf53dc4846fc29070d0115844)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f63e1edefb12824fa5b0e7ab3bd910ea775ca013
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Fri Jul 24 18:20:52 2020 -0700
gallium/dri2: Report correct YUYV and UYVY plane count
Return the actual number of planes in these formats (one) instead of the
number of planes used for lowering (two).
Fixes: d5c857837aa ("gallium/dri2: Fix creation of multi-planar modifier images")
Acked-by: Anuj Phogat <anuj.phogat at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6449>
(cherry picked from commit 36bd3e986830bbf7435389cdd68e593b8b43f234)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b445b12c0d9b86ed17fbbe513e94bd15ade8080d
Author: Rob Clark <robdclark at chromium.org>
Date: Tue Aug 25 09:50:59 2020 -0700
freedreno/gmemtool: add tile_alignw/h and a650
Fixes: f6f8a190920 ("freedreno/a6xx: split up gmem/tile alignment requirements")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6461>
(cherry picked from commit 758fdb9f3315d9ee4c31ed90e379f98928acd8b5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=10571677e5429347d4be47eea1f352da351c067d
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Aug 25 13:54:38 2020 -0400
radeonsi: fix tess levels coming as scalar arrays from SPIR-V
This fixes: KHR-GL45.gl_spirv.spirv_modules_positive_test
Fixes: 75ce078a0af "radeonsi: enable NIR by default and document GL 4.6 support"
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6460>
(cherry picked from commit a61890883ddb993cce1b94ccff20b638acd0a4f7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d4056d25d19e5fdcdeaa53c49d52730054c03955
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Tue Aug 25 13:41:20 2020 +0200
radv: Update CTS version.
CC: 20.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6444>
(cherry picked from commit 83139aca59a6d7da4c4b0abfcc1371f6fc076729)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd1d4bba42e39e3cc7ea4aa7ab9b25f9d7528d66
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Mon Aug 24 21:33:35 2020 +0200
radv: Remove conformance warnings with ACO.
Nobody complained about our conformance submissions.
CC: 20.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6444>
(cherry picked from commit 4e30191c9d3e5cdb1b65d4563f2b74e9bfdcf243)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=33653e6dde2ff85b7b5be64c59e5b8f309e7c045
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Aug 21 23:13:06 2020 +0300
anv: fix transform feedback surface size
Non multiple 4 sizes are causing issue in particular < 4.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3450
Fixes: 36ee2fd61c8f ("anv: Implement the basic form of VK_EXT_transform_feedback")
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6430>
(cherry picked from commit fd10cb8cfccb8882e33a1ade047fc467b9716f54)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c1e2e33752e967511b6311ba7687d8422c263fc9
Author: Vinson Lee <vlee at freedesktop.org>
Date: Wed Aug 19 18:56:19 2020 -0700
meson: Fix lmsensors warning message.
Fixes: 138c003d2273 ("meson: deprecated 'true' and 'false' in combo options for 'enabled' and 'disabled'")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6397>
(cherry picked from commit 855afe01449690e1ed21f9085718551e5ea09bbd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d27e1776e1da04e387f267a652d77787f448ba54
Author: Rob Clark <robdclark at chromium.org>
Date: Fri Aug 21 15:58:37 2020 -0700
freedreno: handle case of shadowing current render target
If you have a sequence where there is a single buffer associated with
the current render target, and then you end up shadowing it on the 3d
pipe (u_blitter), because of how we swap the new shadow and rsc before
the back-blit, you could end up confusing things into thinking that
the blitters framebuffer state is the same as the current framebuffer
state.
Re-organizing the sequence to swap after the blit is complicated when
also having to deal with CPU memcpy blit path, and the batch/rsc
accounting. So instead just detect this case and flush if we need to.
Fixes:
dEQP-GLES31.functional.stencil_texturing.render.depth24_stencil8_clear
dEQP-GLES31.functional.stencil_texturing.render.depth24_stencil8_draw
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6434>
(cherry picked from commit 1fa43a4a8ec37aacac4d333a4c72987819188e69)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=83df231acd2e311334d084c178ff82f262b0b800
Author: Marek Olšák <marek.olsak at amd.com>
Date: Wed Aug 12 11:09:43 2020 -0400
st/mesa: don't generate NIR for ARB_vp/fp if NIR is not preferred
Fixes: 5d0630e5043fc2 "st/mesa: call prog_to_nir sooner for ARB_fp"
Fixes: a3de63fbb3d63e "st/mesa: don't generate VS TGSI if NIR is enabled"
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6442>
(cherry picked from commit 2424485fb436b2abeca2dc801ffda156e3d1fe78)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=786e6a2af8e4ab0c9170637aca7601575ed944c2
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Aug 13 15:12:15 2020 -0500
clover/spirv: Don't call llvm::regularizeLlvmForSpirv
writeSpirv() already takes care of that, and calling it twice seems to
duplicate functions and cause problems when processing execution modes.
Fixes: 2043c5f37cf "clover/llvm: Add functions for compiling from..."
Acked-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Pierre Moreau <dev at pmoreau.org>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6306>
(cherry picked from commit e3e45e2456d2dc7eccf03d7c93bc9cee823a1eec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dee7acec82167cc1a797d2121248e0e9d89d175e
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Aug 28 11:26:42 2020 -0700
.pick_status.json: Mark e93979ba599355c42df01a89073362b970489a3a as denominated
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db0a93de12e2526da65bea7173c832d172343e33
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Aug 28 11:26:39 2020 -0700
.pick_status.json: Update to 7fbded8b5821a47c26245b181446f972f920a96e
More information about the mesa-commit
mailing list