Mesa (master): pan/mdg: Fix spilling of non-32-bit types

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Sep 9 21:44:35 UTC 2020


Module: Mesa
Branch: master
Commit: a4885d26915d290192f3bb5e5f50355cfa266a59
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a4885d26915d290192f3bb5e5f50355cfa266a59

Author: Icecream95 <ixn at keemail.me>
Date:   Wed Sep  9 18:22:00 2020 +1200

pan/mdg: Fix spilling of non-32-bit types

The source argument for mov has index 1, not 0.

Fixes a vertex shader in SuperTuxKart.

Fixes: b4de9e035ac ("pan/mdg: Mask spills from texture write")
Reported-by: macc24
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>~
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6659>

---

 src/panfrost/midgard/midgard_ra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/panfrost/midgard/midgard_ra.c b/src/panfrost/midgard/midgard_ra.c
index 9f0091d09e8..6eb7368d581 100644
--- a/src/panfrost/midgard/midgard_ra.c
+++ b/src/panfrost/midgard/midgard_ra.c
@@ -861,7 +861,7 @@ mir_spill_register(
                                 st = v_mov(spill_node, spill_slot);
                                 st.no_spill |= (1 << spill_class);
                                 st.mask = ins->mask;
-                                st.dest_type = st.src_types[0] = ins->dest_type;
+                                st.dest_type = st.src_types[1] = ins->dest_type;
                         } else {
                                 ins->dest = spill_index++;
                                 ins->no_spill |= (1 << spill_class);



More information about the mesa-commit mailing list