Mesa (master): nv50/ir: Add fallthrough statement.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Sep 11 00:43:56 UTC 2020


Module: Mesa
Branch: master
Commit: a2a330a4edadb5e477d24211091415f82c284fc8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a2a330a4edadb5e477d24211091415f82c284fc8

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Sep  7 21:15:03 2020 -0700

nv50/ir: Add fallthrough statement.

Fix defect reported by Coverity Scan.

Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value
nir_intrinsic_bindless_image_samples is not terminated by a 'break'
statement.

Suggested-by: Karol Herbst <kherbst at redhat.com>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6645>

---

 src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index b9a82a037e8..393b88a92ed 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
@@ -2220,6 +2220,7 @@ Converter::visit(nir_intrinsic_instr *insn)
          break;
       case nir_intrinsic_bindless_image_samples:
          mask = 0x8;
+         /* fallthrough */
       case nir_intrinsic_image_samples:
          ty = TYPE_U32;
          bindless = op == nir_intrinsic_bindless_image_samples;



More information about the mesa-commit mailing list