Mesa (master): freedreno: fix fence-fd leak

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Sep 11 20:41:10 UTC 2020


Module: Mesa
Branch: master
Commit: eceb4fb904bdc99782c53e1af1b3677f2fbab0d2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eceb4fb904bdc99782c53e1af1b3677f2fbab0d2

Author: Rob Clark <robdclark at chromium.org>
Date:   Fri Sep 11 13:11:52 2020 -0700

freedreno: fix fence-fd leak

sync_accumulate() does not take ownership.

Fixes: bf23ff83e69 ("freedreno: fence_server_sync() fixes")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6692>

---

 src/gallium/drivers/freedreno/freedreno_context.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/freedreno/freedreno_context.h b/src/gallium/drivers/freedreno/freedreno_context.h
index 235c8e56731..f1ecfcdb351 100644
--- a/src/gallium/drivers/freedreno/freedreno_context.h
+++ b/src/gallium/drivers/freedreno/freedreno_context.h
@@ -519,6 +519,7 @@ fd_context_switch_to(struct fd_context *ctx, struct fd_batch *batch)
 {
 	if (ctx->in_fence_fd != -1) {
 		sync_accumulate("freedreno", &batch->in_fence_fd, ctx->in_fence_fd);
+		close(ctx->in_fence_fd);
 		ctx->in_fence_fd = -1;
 	}
 }



More information about the mesa-commit mailing list