Mesa (master): radesonsi: Remove unsigned comparison to zero.

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: fcc506e52060ce0b2db756c7b07c70a781fac8c3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcc506e52060ce0b2db756c7b07c70a781fac8c3

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Sep 14 21:59:55 2020 -0700

radesonsi: Remove unsigned comparison to zero.

cbuf was changed to unsigned in commit 3fec2f67c3d9 ("radeonsi:
compact MRTs to save PS export memory space").

Fix defect reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison of
an unsigned value is always true. cbuf >= 0U.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6739>

---

 src/gallium/drivers/radeonsi/si_shader_llvm_ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeonsi/si_shader_llvm_ps.c b/src/gallium/drivers/radeonsi/si_shader_llvm_ps.c
index 1f233e1b96c..37711eefa04 100644
--- a/src/gallium/drivers/radeonsi/si_shader_llvm_ps.c
+++ b/src/gallium/drivers/radeonsi/si_shader_llvm_ps.c
@@ -253,7 +253,7 @@ static void si_llvm_init_ps_export_args(struct si_shader_context *ctx, LLVMValue
    unsigned chan;
    bool is_int8, is_int10;
 
-   assert(cbuf >= 0 && cbuf < 8);
+   assert(cbuf < 8);
 
    spi_shader_col_format = (col_formats >> (cbuf * 4)) & 0xf;
    is_int8 = (key->part.ps.epilog.color_is_int8 >> cbuf) & 0x1;