Mesa (staging/20.2): 27 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Sep 24 15:46:59 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=627fd4de48fc09cba1ffa8038653172bf351160b
Author: Michel Dänzer <mdaenzer at redhat.com>
Date: Mon Sep 21 19:27:51 2020 +0200
ci: Use ignore_scheduled_pipelines anchor in .radeonsi-rules
Without this, scheduled pipelines erroneously tried to create jobs using
this template, which can't work, because their dependency jobs don't
exist in scheduled pipelines. Unfortunately, this resulted in scheduled
pipelines not running silently, without any direct feedback about what's
wrong (see https://gitlab.com/gitlab-org/gitlab/-/issues/25490).
Fixes: 6c8b921572a5 "ci: Build kernels and rootfs for x86 devices"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6802>
(cherry picked from commit a1f46d7b6943699e5efb60fbcfdd1450db85adb1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd2bf6927d5ddbf5c1fbdc89a95a4ec8238ed15a
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Fri Aug 21 17:21:14 2020 +0300
nir/lower_samplers: Clamp out-of-bounds access to array of samplers
Section 5.11 (Out-of-Bounds Accesses) of the GLSL 4.60 spec says:
"In the subsections described above for array, vector, matrix and
structure accesses, any out-of-bounds access produced undefined
behavior.... Out-of-bounds reads return undefined values, which
include values from other variables of the active program or zero."
Robustness extensions suggest to return zero on out-of-bounds
accesses, however it's not applicable to the arrays of samplers,
so just clamp the index.
Otherwise instr->sampler_index or instr->texture_index would be out
of bounds, and they are used as an index to arrays of driver state.
E.g. this fixes such dereference:
if (options->lower_tex_packing[tex->sampler_index] !=
in nir_lower_tex.c
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6428>
(cherry picked from commit f2b17dec1208423061309e0e03ba32b2c5566ace)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=405b2db563c13f58ea0af74b83850086bdf69904
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Fri Aug 21 16:35:28 2020 +0300
nir/large_constants: Eliminate out-of-bounds writes to large constants
Out-of-bounds writes could be eliminated per spec:
Section 5.11 (Out-of-Bounds Accesses) of the GLSL 4.60 spec says:
"In the subsections described above for array, vector, matrix and
structure accesses, any out-of-bounds access produced undefined
behavior.... Out-of-bounds writes may be discarded or overwrite
other variables of the active program."
Fixes: 1235850522cd5e7b07701f7065996430ca1514b6
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6428>
(cherry picked from commit 0ba82f78a57d352c1042678962e8a386b411322f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=06aaa22ce4e08ae56e24837cfe0a0ff257afa27d
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Fri Aug 21 13:42:55 2020 +0300
nir/lower_io: Eliminate oob writes and return zero for oob reads
Out-of-bounds writes could be eliminated per spec:
Section 5.11 (Out-of-Bounds Accesses) of the GLSL 4.60 spec says:
"In the subsections described above for array, vector, matrix and
structure accesses, any out-of-bounds access produced undefined
behavior....
Out-of-bounds writes may be discarded or overwrite
other variables of the active program.
Out-of-bounds reads return undefined values, which
include values from other variables of the active program or zero."
GL_KHR_robustness and GL_ARB_robustness encourage us to return zero
for reads.
Otherwise get_io_offset would return out-of-bound offset which may
result in out-of-bound loading/storing of inputs/outputs,
that could cause issues in drivers down the line.
E.g. this fixes such dereference:
int vue_slot = vue_map->varying_to_slot[intrin->const_index[0]];
in brw_nir.c
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6428>
(cherry picked from commit 66669eb5295c207622425d9767422a62e1228407)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3765799b2bf7aab42bcc32cb21b6ffd301489b4f
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sat Sep 19 17:28:17 2020 +0200
st/mesa: Deal with empty textures/buffers in semaphore wait/signal.
The actual texture might not have been created yet.
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3257
CC: mesa-stable
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6788>
(cherry picked from commit ade72e677b3e3d15221c0097c76573c36e47d0f8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dbcacbb474a713a973aa399ccdffc3216c9c7f66
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Sep 15 15:33:14 2020 +0300
intel/compiler: fixup Gen12 workaround for array sizes
We didn't handle the case of NULL images/textures for which we should
return 0.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 397ff2976ba281 ("intel: Implement Gen12 workaround for array textures of size 1")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3522
Reviewed-by: Ivan Briano <ivan.briano at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6729>
(cherry picked from commit cc3bf00cc26ddb991b4036a9911299e7d122115b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3eb8e220fb03fc5d8f421bd40345349a9d4edc6e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Sep 21 13:43:49 2020 +0200
radv: fix transform feedback crashes if pCounterBufferOffsets is NULL
From the Vulkan 1.2.154 spec:
"If pCounterBufferOffsets is NULL, then it is assumed the
offsets are zero."
Fix new CTS
dEQP-VK.transform_feedback.simple.backward_dependency_no_offset_array.
CC: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6798>
(cherry picked from commit 2b99e15d0a6440edc0a616b031376a025247ece4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b51300214044c3c88d0cbfca3a6864b98988b8ba
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Sep 17 14:41:27 2020 +0100
radv,aco: fix reading primitive ID in FS after TES
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3530
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6760>
(cherry picked from commit 2228835fb55225c68f059f86bdd64f81bcb92c74)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ac5208988993ead3c817622f7103f44fdb8d7160
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Thu Aug 13 23:29:15 2020 +0200
ac/surface: Fix depth import on GFX6-GFX8.
Lets just do depth interop imports by convention between radv and
radeonsi for now. The only thing using this should be Vulkan interop
anyway.
CC: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6617>
(cherry picked from commit ecc19e9819c021d5e10246492284d8f68b019315)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3a610707e2fa808806c88744f94737132846a3bf
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Sep 23 11:57:48 2020 -0700
amd/ac_surface: convert tabs to 3 spaces
To make patches from master better apply
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b50edc9681b8ae21b3720aad71803b062e409b2e
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Sep 18 18:11:10 2020 -0500
intel/fs/swsb: SCHEDULING_FENCE only emits SYNC_NOP
It's not really unordered in the sense that it can still stall on
ordered things and we don't need a SYNC_NOP for that because it is a
SYNC_NOP. However, it also doesn't count when computing instruction
distances.
Fixes: 18e72ee2108 "intel/fs: Add FS_OPCODE_SCHEDULING_FENCE"
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6781>
(cherry picked from commit f63ffc18e79a94ff7a4c418341e644cc3894a03a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40f773113220b8fb1667cfb6c98f69b2a7d8ac25
Author: Qiang Yu <yuq825 at gmail.com>
Date: Fri Sep 18 20:03:46 2020 +0800
radeonsi: fix user fence GPU address
User fence should have 4 QWORD memory space, I updated its CPU address
but forgot to update GPU address.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3513
Fixes: 3d5bed0e883 "radeonsi: fix user fence space when MCBP is enabled"
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6776>
(cherry picked from commit 4656e682947621829f9297f01b2aaffb384bb762)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=981cdea605012d0c55b89a0ebd8e04b3e7dbb27a
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Thu Sep 17 15:07:53 2020 -0700
glsl_type: Add packed to structure type comparison for hash map
Fixes: 659f333b3a4ff "glsl: add packed for struct types"
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6767>
(cherry picked from commit 9aa86eb61aa64411b4c16d359467312f0f2729a0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8724f7965abcb35fad5cf795fa49be6919d1d78c
Author: Pierre-Loup A. Griffais <git at plagman.net>
Date: Fri Sep 18 00:25:08 2020 -0700
radv: fix vertex buffer null descriptors
Fixes: 0f1ead7b536 "radv: handle NULL vertex bindings"
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6773>
(cherry picked from commit 7b4eaac6a9c02c7e06b6633b6ad4cedef1833ef9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff44b81e32da063eb55398cf9651b52738efc928
Author: Pierre-Loup A. Griffais <git at plagman.net>
Date: Thu Sep 17 23:27:49 2020 -0700
radv: fix null descriptor for dynamic buffers
Fixes: c1ef225d183 "radv: handle NULL descriptors"
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6772>
(cherry picked from commit ec13622ff4bae3818d27561d3b8ba1836556db40)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fa3ae51fb384a762157c096d3f8acfd12e5d806
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Mon Sep 14 21:08:29 2020 +0200
mesa: fix glUniform* when a struct contains a bindless sampler
Small example from #3271:
layout (bindless_sampler) uniform;
struct SamplerSparse {
sampler2D tex;
vec4 size;
[...]
};
uniform SamplerSparse foo;
'foo' will be marked as bindless but we should only take the assign-as-GLuint64 path for 'tex'.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3271
Fixes: 990c8d15ac3 ("mesa: fix setting uniform variables for bindless samplers/images")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6730>
(cherry picked from commit 090fc593b44d41e5613b04931bbf46d268fca666)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9c756d7b253ede2d70b74eeccb3c37a88d2d5c35
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Sep 14 17:53:31 2020 -0700
panfrost: Delete debug allocated syncobj.
Fix defect reported by Coverity Scan.
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: drmSyncobjDestroy(dev->fd, ...
Fixes: 64d6f56ad26f ("panfrost: Allocate syncobjs in panfrost_flush")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6720>
(cherry picked from commit ffbdbd631ad9aa391f5160bf50d6849d98bb6de4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=21fdbf0333eb2474fe167298a1237cde99e2081d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Sep 15 19:55:47 2020 +0100
radv: initialize with expanded cmask if the destination layout needs it
If radv_layout_can_fast_clear() is false, 028C70_COMPRESSION is unset when
the image is rendered to and CMASK isn't updated. This appears to cause
FMASK to be ignored and the 0th sample to always be used.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3449
Fixes: 7b21ce401f7e81deca5ab6a4353b1369d059bcee
('radv: disable FMASK compression when drawing with GENERAL layout')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6745>
(cherry picked from commit 85cc2950a045ca0fe153498fb7d48322d2906482)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c473d28ef718a2d69862849abd89a8f59aeb9e5
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Wed Sep 2 12:07:00 2020 +0200
radeon/vcn: set dec->bs_ptr = NULL on unmap
To avoid using a dangling pointer.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/1308
Cc: mesa-stable
Reviewed-by: Boyuan Zhang <boyuan.zhang at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6556>
(cherry picked from commit 7d853966df4f6d0ded845a6ba2b2af7c46404157)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=68da391e0566864ecd9b6be860d503bcfeb92b29
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Wed Sep 2 11:58:12 2020 +0200
r600/uvd: set dec->bs_ptr = NULL on unmap
To avoid using a dangling pointer.
See https://gitlab.freedesktop.org/mesa/mesa/-/issues/1308
Cc: mesa-stable
Reviewed-by: Boyuan Zhang <boyuan.zhang at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6556>
(cherry picked from commit eb60849ea2484c6ba09843ce1c29ba161fa6d02e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7489db2793179186d212fc8b5fd29eba6d481a6e
Author: Vinson Lee <vlee at freedesktop.org>
Date: Fri Sep 11 16:00:07 2020 -0700
freedreno: Check file descriptor before write.
Fix defect reported by Coverity Scan.
Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: fd is passed to a parameter that cannot be
negative.
Fixes: 1ea4ef0d3be8 ("freedreno: slurp in decode tools")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6696>
(cherry picked from commit e607477d7ca2550c0b7f53f3886b4b6fd055d779)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8992f30204ebde3c8ba33aed1fc05db74cf88739
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Fri Jul 31 13:12:34 2020 -0400
pan/bit: Set d3d=true for CMP tests
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Fixes: ec37c7126dc ("bifrost: Emit "d3d" variant of comparison instructions")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6712>
(cherry picked from commit c4f518ce6a67508eaf4b16671f9a5d2777c74783)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=317f736faea351655740ec99af56d96131e32152
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Fri Sep 11 15:45:48 2020 +0200
glsl: fix per_vertex_accumulator::fields size
49d35f3d882bd0f4418a1ce056344b8f06bd75dd moved gl_Layer/gl_ViewportIndex/gl_ViewportMask
as builtins but fields size wasn't increased.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3508
Fixes: 49d35f3d882 ("glsl: declare gl_Layer/gl_ViewportIndex/gl_ViewportMask as vs builtins")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6688>
(cherry picked from commit 8a2a9e9bb8879cf3e88870fc5ff4c36e190fa012)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0ce22a2a31e01de332f2228de847d438b4db70f
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Sat Sep 12 13:20:06 2020 +0200
aco: Fix emit_boolean_exclusive_scan in wave32 mode.
Use the lane mask instead of s2 for the register class.
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6699>
(cherry picked from commit efa1c760d15fb645bed9d6c83e73a770b2fe0bd6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dfe2f4fd5db0d799680fe8cd34b77338a00f31c0
Author: Jordan Justen <jordan.l.justen at intel.com>
Date: Sun Mar 29 02:16:06 2020 -0700
anv, iris: Set MediaSamplerDOPClockGateEnable for gen12+
This has been shown to help performance on TGL and DG1. This could be
applied to gen9+, but we still need to show if it helps with those
platforms.
Rework:
* Make change in src/intel/vulkan/genX_cmd_buffer.c too. (Ken)
* Keep mask as 3 for gen < 12
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6684>
(cherry picked from commit 20a4235c4c96592e13648da494ca446288ac9a2f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c747589282b06d0df44b9c1971195bd4ed4f12dc
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Sep 22 15:16:43 2020 -0700
.pick_status.json: Update to a1f46d7b6943699e5efb60fbcfdd1450db85adb1
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3586c2da6a268016c05fa32a67bf60d60e63075
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Sep 22 15:13:55 2020 -0700
fixe: gallivm: disable brilinear for lod bias and explicit lod.
This is a mistake by me in resolving conflicts, and then I accidentally
pushed to the stable branch, so this cannot be rebased by policy like I
would normally do.
More information about the mesa-commit
mailing list