Mesa (master): r600/sfn: Initialize GPRValue member m_pin_to_channel.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Sep 25 00:38:07 UTC 2020


Module: Mesa
Branch: master
Commit: 4bd0df0e4a8cd600c17a01b3bf297b0d06cb6e44
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4bd0df0e4a8cd600c17a01b3bf297b0d06cb6e44

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Tue Sep 22 17:41:35 2020 -0700

r600/sfn: Initialize GPRValue member m_pin_to_channel.

Fix defects reported by Coverity Scan.

Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member m_pin_to_channel is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6830>

---

 src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
index dba5c0468e4..f4dcb68ca2f 100644
--- a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
+++ b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
@@ -38,7 +38,8 @@ GPRValue::GPRValue(uint32_t sel, uint32_t chan, int base_offset):
    Value(Value::gpr, chan),
    m_sel(sel),
    m_base_offset(base_offset),
-   m_input(false)
+   m_input(false),
+   m_pin_to_channel(false)
 {
 }
 
@@ -46,7 +47,8 @@ GPRValue::GPRValue(uint32_t sel, uint32_t chan):
    Value(Value::gpr, chan),
    m_sel(sel),
    m_base_offset(0),
-   m_input(false)
+   m_input(false),
+   m_pin_to_channel(false)
 {
 }
 



More information about the mesa-commit mailing list