Mesa (master): panfrost: Remove extra printf arguments.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Sep 28 09:03:43 UTC 2020
Module: Mesa
Branch: master
Commit: d9c4ec91542662f7297591b92ed6c4a452004d2b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9c4ec91542662f7297591b92ed6c4a452004d2b
Author: Vinson Lee <vlee at freedesktop.org>
Date: Tue Sep 22 17:22:12 2020 -0700
panfrost: Remove extra printf arguments.
Fix defects reported by Coverity Scan.
Extra argument to printf format specifier (PRINTF_ARGS)
extra_argument: This argument was not used by the format string: job +
32UL.
Fixes: 89fafe9e926b ("panfrost: XML-ify the fragment job descriptor")
Fixes: d289209ea68f ("panfrost: XML-ify the compute job descriptor")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6829>
---
src/panfrost/lib/decode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/panfrost/lib/decode.c b/src/panfrost/lib/decode.c
index fec27033c8c..63567968a44 100644
--- a/src/panfrost/lib/decode.c
+++ b/src/panfrost/lib/decode.c
@@ -1385,7 +1385,7 @@ pandecode_tiler_job_mdg(const struct MALI_JOB_HEADER *h,
pan_section_unpack(p, MIDGARD_TILER_JOB, DRAW, draw);
pandecode_vertex_tiler_postfix_pre(&draw, job_no, h->type, "", false, gpu_id);
- pandecode_log("Tiler Job Payload:\n", job + MALI_JOB_HEADER_LENGTH);
+ pandecode_log("Tiler Job Payload:\n");
pandecode_indent++;
pandecode_invocation(pan_section_ptr(p, MIDGARD_TILER_JOB, INVOCATION), true);
pandecode_primitive(pan_section_ptr(p, MIDGARD_TILER_JOB, PRIMITIVE));
@@ -1461,8 +1461,7 @@ pandecode_fragment_job(const struct pandecode_mapped_memory *mem,
pandecode_msg("XXX: tile coordinates overflow in Y direction\n");
/* After validation, we print */
- DUMP_UNPACKED(FRAGMENT_JOB_PAYLOAD, s, "Fragment Job Payload:\n",
- job + MALI_JOB_HEADER_LENGTH, job_no);
+ DUMP_UNPACKED(FRAGMENT_JOB_PAYLOAD, s, "Fragment Job Payload:\n");
/* The FBD is a tagged pointer */
More information about the mesa-commit
mailing list