Mesa (master): intel/compiler: Don't fallback to vec4 when scalar GS compile fails [v2]

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Sep 28 19:32:20 UTC 2020


Module: Mesa
Branch: master
Commit: 86bab92aa4aac91e8d8730e7344e9bbb44e062ab
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=86bab92aa4aac91e8d8730e7344e9bbb44e062ab

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Tue Sep 22 13:04:47 2020 -0700

intel/compiler: Don't fallback to vec4 when scalar GS compile fails [v2]

v2: Add missing error string handling.  Noticed by Jason.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Matt Turner <mattst88 at gmail.com> [v1]
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6826>

---

 src/intel/compiler/brw_vec4_gs_visitor.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/intel/compiler/brw_vec4_gs_visitor.cpp b/src/intel/compiler/brw_vec4_gs_visitor.cpp
index 05cbab26620..615b2966805 100644
--- a/src/intel/compiler/brw_vec4_gs_visitor.cpp
+++ b/src/intel/compiler/brw_vec4_gs_visitor.cpp
@@ -872,6 +872,11 @@ brw_compile_gs(const struct brw_compiler *compiler, void *log_data,
          g.add_const_data(nir->constant_data, nir->constant_data_size);
          return g.get_assembly();
       }
+
+      if (error_str)
+         *error_str = ralloc_strdup(mem_ctx, v.fail_msg);
+
+      return NULL;
    }
 
    if (compiler->devinfo->gen >= 7) {



More information about the mesa-commit mailing list