Mesa (master): zink: add some asserts to avoid zero-sized blit regions
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Apr 2 14:23:28 UTC 2021
Module: Mesa
Branch: master
Commit: 9d8dd8d27b6e0963b7ec6a6987cce37f5731ae2f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9d8dd8d27b6e0963b7ec6a6987cce37f5731ae2f
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Apr 1 22:41:07 2021 -0400
zink: add some asserts to avoid zero-sized blit regions
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9999>
---
src/gallium/drivers/zink/zink_blit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/zink/zink_blit.c b/src/gallium/drivers/zink/zink_blit.c
index 43cc89cd054..980b8fad6cc 100644
--- a/src/gallium/drivers/zink/zink_blit.c
+++ b/src/gallium/drivers/zink/zink_blit.c
@@ -170,6 +170,8 @@ blit_native(struct zink_context *ctx, const struct pipe_blit_info *info)
region.dstOffsets[0].y = info->dst.box.y;
region.dstOffsets[1].x = info->dst.box.x + info->dst.box.width;
region.dstOffsets[1].y = info->dst.box.y + info->dst.box.height;
+ assert(region.dstOffsets[0].x != region.dstOffsets[1].x);
+ assert(region.dstOffsets[0].y != region.dstOffsets[1].y);
switch (dst->base.b.target) {
case PIPE_TEXTURE_CUBE:
@@ -196,6 +198,7 @@ blit_native(struct zink_context *ctx, const struct pipe_blit_info *info)
region.dstOffsets[0].z = 0;
region.dstOffsets[1].z = 1;
}
+ assert(region.dstOffsets[0].z != region.dstOffsets[1].z);
vkCmdBlitImage(batch->state->cmdbuf, src->obj->image, src->layout,
dst->obj->image, dst->layout,
More information about the mesa-commit
mailing list