Mesa (master): 40 new commits

Wed Apr 14 09:15:45 UTC 2021

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7fbd7bb7cb2b9b7f4d440f6e695f28fc9ea749b7
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:53:07 2021 +0200

    st/nine: Default tearfree_discard to true
    
    With tearfree_discard=false, we tear when rendering
    fullscreen apps with vsync off.
    
    This is a feature in the sense it's the same as the native
    implementation. This also means lower input lag.
    
    However I think most users will prefer to have no tearing,
    and don't care about sub refresh-rate input lag.
    
    Thus it's better to default tearfree_discard to true.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c19a841fd4a60fef444d9047e19aae788f6a5251
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:40:20 2021 +0200

    st/nine: Default thread_submit to true
    
    When rendering fullscreen with vsync on at
    a rate close to the refresh rate, you can
    miss pageflips by submitting buffers for pageflip
    that end up not finished being rendered when the pageflip is due.
    
    With Nine in this situation you could get half the refresh
    rate fps before this patch.
    
    Due to the way the presentation backend is implemented,
    it's not possible to easily detect the situation and adapt (use
    one more backbuffer, but only in this scenario to not increase input
    lap when the issue is not present).
    
    thread_submit doesn't have this issue.
    
    Let's default thread_submit to true.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a2a95abb6c32529e16359dc75f77caa32df489f2
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 21:28:39 2021 +0100

    st/nine: Improve performance with thread_submit
    
    Use the Async flush flag to return faster during
    Present() when thread_submit is used.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=062c4cc0b9bb9dce6c1e79d0f722ba1ac50462fd
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 8 18:44:32 2021 +0100

    st/nine: Bump num of backbuffers for tearfree thread_submit
    
    Running some high fps benchmarks, thread_submit gets
    subpar fps with the option tearfree_discard.
    Increasing the number of backbuffers fixes it.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=53f4766a3ebfdd17dbec66ae77551d8c3f3cce6f
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:01:16 2021 +0200

    st/nine: Lower texture_memory_limit default
    
    512 MB is too ambitious as default value.
    128 MB seems safer, and users can increase the limit
    manually for the few games that would benefit from it.
    
    Also fixes a typo in the description
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b41f1e32e96c973dba8981e8e66e68730aaa35a8
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 22:52:47 2021 +0200

    st/nine: Make it optional to use a sw renderer
    
    Until the problem described in
    https://gitlab.freedesktop.org/mesa/mesa/-/issues/4489
    is fixed, the advantages of using a sw renderer for the
    sw rendering in nine are too small compared to the
    disadvantages.
    
    Add an option to control whether we use a sw renderer,
    and make it so by default we don't.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c5f75bc2001126c688b384ce18221a8db02c2cfd
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 15 22:35:26 2021 +0100

    st/nine: Allow to override the vram size
    
    This can be useful for debugging, or for some apps
    not supporting >= 4GB of vram.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=26a42f105344836c04e7fbe85c2ffb90b59b6fac
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 8 18:48:23 2021 +0100

    st/nine: Disable buffer_upload when csmt is off
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5702b15cd9d6105111210f8d5521b413e0403cd7
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 13 22:39:28 2021 +0100

    st/nine: Use PIPE_MAP_ONCE for persistent buffers
    
    This enables radeonsi to really unmap on release,
    which reduces virtual memory usage.
    
    Do it only on 32 bits, as it can reduce performance if the
    allocation is reused.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ac9c9c6675023941ea6460602a9e028a9343b51
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 21:58:59 2021 +0200

    st/nine: Add fallback for YUV formats
    
    Adds alternative format to store YUV textures/surfaces.
    
    These will be converted on upload to the alternative format.
    Fixes: https://github.com/iXit/wine-nine-standalone/issues/39
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=25d203a1166bc4ad0803d02216b22f6ba6fb9280
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:22:06 2021 +0200

    st/nine: Do not memset buffers twice
    
    No need to apply memset on an allocation
    from align_calloc.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=805cedd2077782be329b53bbe8a986301b28d0d6
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 27 22:33:06 2021 +0100

    st/nine: Have NOOVERWRITE win over DISCARD
    
    I held for a long time the belief DISCARD wins
    over NOOVERWRITE, backed by experiments.
    
    But probably both behaviours are ok.
    For perf it is better to have NOOVERWRITE win.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1797a6eb047fcb01cda609046c039c9c6e4e873d
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 15 23:42:47 2021 +0100

    st/nine: Add logging to Ex function
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4953d19518dc47d3a13441b425b4be67c526e9f5
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 15 22:22:05 2021 +0100

    st/nine: Complete *Ex stubs
    
    Returning D3D_OK instead of an error when it
    makes sense.
    Return the value passed previously (or the default)
    when it makes sense.
    Add (void)variable for unused input variables.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c72f7506e6618c51b6a0b71f9608ba15f5e52b3
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Mon Mar 15 22:02:37 2021 +0100

    st/nine: Pseudo implement Create*Ex functions
    
    It seems some apps use them.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=006338f7025a99405ba7821c8a28648b38feaa25
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 15:07:06 2021 +0100

    st/nine: Improve Reset on Ex devices
    
    Found with wine tests
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee580c96efc356b4ade51c7cc6201fc2aa170e6a
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Wed Mar 10 22:38:14 2021 +0100

    st/nine: Pseudo implement set/getClipstatus
    
    Not sure why any app would use this in production,
    it seems like a debugging feature. Still some do make
    the calls.
    
    Fixes: https://github.com/iXit/wine-nine-standalone/issues/99
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a1bb1b9b07f4091f95fc1368cb2b3039ebfe0c50
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 15:57:13 2021 +0100

    st/nine: Catch redundant scissor and viewport settings
    
    The redundancy check is done in the nine_context function,
    rather than the device function, in order to also filter
    calls from SetRenderTarget and Reset*.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0caa05d4201347efd851fc36f69ee0889521f9e
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 27 13:45:17 2021 +0100

    st/nine: Fix ff has_aNrm computation
    
    In some cases the wrong computation led the
    normal to be zero instead of the correct value,
    which led to artifacts.
    
    Fixes: https://github.com/iXit/wine-nine-standalone/issues/105
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a0288fa3b73d9edb26264d892f934e18c07ae8ae
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 27 12:36:34 2021 +0100

    st/nine: Fix ps ff BLENDTEXTUREALPHA
    
    This ff ps operation has the texture alpha as input.
    Thus we need to sample the texture.
    
    Fixes: https://github.com/iXit/wine-nine-standalone/issues/105
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e9644666e9ba226edf22ab652c05fb148643f79
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 20 13:50:45 2021 +0100

    st/nine: Refuse depth buffers as rendertargets
    
    If we allow them, some apps try to use them
    as rendertargets.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a849923aea378bcd928581e15267ac8136a46b25
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Thu Mar 18 23:36:28 2021 +0100

    st/nine: Clamp max_anisotropy
    
    GL does the same.
    
    Fixes the low texture quality issue of
    https://github.com/iXit/wine-nine-standalone/issues/21
    
    The are some indications it might not be the native
    behaviour (which makes sense, the native filtering
    of states seems more to not update internal states
    when the passed value is invalid).
    However it's better visually to have anisotropic filtering
    enabled in these buggy cases.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=619c53489fc5d363317f5e176f0e0271a1e90a33
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Thu Mar 11 18:33:24 2021 +0100

    st/nine: Ignore swizzle on samplers
    
    Prevents a crash running wine tests
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=787b03d5f6d7e08ad9f52b926a9afc086768f44e
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 13:38:59 2021 +0100

    st/nine: Increase number of constants of vs1_sw
    
    Wine tests seem to indicate more the 256 should
    be supported for this case, but I couldn't find the
    doc for how much it should be. Use the vs >= 2
    settings for now.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=138615a094a07ceb92c79ce5c78407eb9c060834
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 21:28:57 2021 +0100

    st/nine: Remove errors on unsupported lock flags
    
    Some applications seem to pass undefined flags...
    And we shouldn't return an error.
    
    Found investigating:
    https://github.com/iXit/wine-nine-standalone/issues/100
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=70f8d78aa7748de1046752ccdf5ebf00ea80cb45
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Thu Mar 11 20:55:48 2021 +0100

    st/nine: Handle D3DFMT_NULL multisampling
    
    When D3DFMT_NULL is set as render target,
    we must take the multisampling state
    from the depth buffer.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=de66d503f7d8667f5b1d035060f79d09dcd4a83c
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Thu Mar 11 20:45:39 2021 +0100

    st/nine: Enable multisampling also without depth buffer
    
    Found with wine tests.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1272640d55243105bb192a5dd460dc70fc7a77a6
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Thu Mar 11 20:43:04 2021 +0100

    st/nine: Fix alpha to coverage states
    
    The sequence of states to disable NVidia alpha
    to coverage was disabling AMD alpha to coverage.
    This patch fixes it.
    
    Found with wine tests.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d03f401fda2525d56db57bcb1dbd2a603cc68a2a
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 15:07:45 2021 +0100

    st/nine: Improve Surface GetContainer
    
    Prevents a crash in wine tests. Not sure
    this behaviour is the correct one, but at
    least it'll check the IID passed is the device
    before returning it.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=17dc334b81f9ea06e3a8960c948a3ef82a0df0e3
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 27 20:55:58 2021 +0100

    st/nine: Prevent negative reference count
    
    Apparently this is a thing, according to wine tests
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=586cede4b6512af265da3c12b4cdb4a30c976c43
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Mar 6 14:40:35 2021 +0100

    st/nine: Fix value of pipe_draw_info's max_index vertex
    
    max_index didn't include draw.start
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5a1f3c98d7724f61a518e954cbf93f5d5be4037
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sun Mar 28 18:32:15 2021 +0200

    st/nine: Fix read outside bounds for some textures
    
    According to wine tests, some apps can allocate very
    small ATI1/ATI2 textures levels.
    
    The issue is that the CPU versions of these textures are stored
    in buffers which size is the same as if the format was uncompressed.
    
    Thus the content filled cannot possibly be correct for these levels.
    
    The tests seems to hint when rendering with these levels the output
    is bad, but at least it the runtime shouldn't crash when using them.
    
    Previously nine would read outside bounds (found with asan) in this
    scenario, as the gallium helper copies a full compressed block.
    
    Instead do not copy anything for these levels.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a6cce52908e511011aef30222bf9de1ae0b71f0a
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sun Mar 28 18:31:57 2021 +0200

    st/nine: Fix compilation warnings
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=68024fc0cc6d05c5a7b59e49bda64fc157757506
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sun Mar 28 18:30:40 2021 +0200

    st/nine: Fix reading invalid pointer
    
    Apparently it is incorrect to use the pointer in
    LIST_FOR_EACH_ENTRY like I used to.
    Found with asan.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2146494d08d7355a7acde352c0f6eebae09f47c3
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sun Mar 28 12:26:48 2021 +0200

    st/nine: Prevent use after free on dtor
    
    Found with asan.
    This->device was accessed after This was destroyed.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8df04b1b2d3eea28655f99dfb308c2414ca90c32
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:19:10 2021 +0200

    st/nine: Fix invalid NULL check
    
    Found with clang warnings.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a5f2084c1b18d427ce0839341b500bdbe9c2a081
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Sat Apr 10 23:18:20 2021 +0200

    st/nine: Add missing breaks
    
    This makes clang warnings happier.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=29cc19e54f482def8248703848b2663feb14b9da
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 13:47:09 2021 +0100

    st/nine: Fix cubetexture early destruction
    
    When the surface creation fails, the dtor
    can face NULL pointers for the surfaces.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=204bc8981f78206ad6c12ca628c59c3645ec0e0c
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 13:16:13 2021 +0100

    st/nine: Fix crash on texture creation failure
    
    Fixes regression introduced by:
    a179ea2e "st/nine: Use the texture memory helper"
    
    The device is used on texture/surface dtor since this commit.
    We need to early fill the device field in case of error.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9e79bfe4f03eb0412a5535fce2a98c10623f53d
Author: Axel Davy <davyaxel0 at gmail.com>
Date:   Fri Mar 12 13:03:01 2021 +0100

    st/nine: Disable fpu exceptions during init
    
    Prevents a crash in wine tests. The crash
    seems to happen in llvmpipe.
    
    Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
    Acked-by: Timur Kristóf <timur.kristof at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10160>