Mesa (master): aco: Remove useless s_setprio near gs_alloc_req.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Apr 14 14:35:37 UTC 2021
Module: Mesa
Branch: master
Commit: 4c86c7aa15bf2fcfce42557fd9fe2731798f2ff9
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4c86c7aa15bf2fcfce42557fd9fe2731798f2ff9
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Thu Apr 8 13:32:01 2021 +0200
aco: Remove useless s_setprio near gs_alloc_req.
We learned that the gs_alloc_req is not actually when the export
space allocation happens. So it makes no sense to prioritize it.
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10106>
---
src/amd/compiler/aco_instruction_selection.cpp | 7 -------
1 file changed, 7 deletions(-)
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index 5d5f7e429b4..57ec804d272 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -11117,9 +11117,6 @@ void ngg_emit_sendmsg_gs_alloc_req(isel_context *ctx, Temp vtx_cnt = Temp(), Tem
{
Builder bld(ctx->program, ctx->block);
- /* It is recommended to do the GS_ALLOC_REQ as soon and as quickly as possible, so we set the maximum priority (3). */
- bld.sopp(aco_opcode::s_setprio, -1u, 0x3u);
-
/* Get the id of the current wave within the threadgroup (workgroup) */
Builder::Result wave_id_in_tg = bld.sop2(aco_opcode::s_bfe_u32, bld.def(s1), bld.def(s1, scc),
get_arg(ctx, ctx->args->ac.merged_wave_info), Operand(24u | (4u << 16)));
@@ -11190,10 +11187,6 @@ void ngg_emit_sendmsg_gs_alloc_req(isel_context *ctx, Temp vtx_cnt = Temp(), Tem
}
end_uniform_if(ctx, &ic);
-
- /* After the GS_ALLOC_REQ is done, reset priority to default (0). */
- bld.reset(ctx->block);
- bld.sopp(aco_opcode::s_setprio, -1u, 0x0u);
}
Temp ngg_pack_prim_exp_arg(isel_context *ctx, unsigned num_vertices, const Temp vtxindex[], const Temp is_null)
More information about the mesa-commit
mailing list