Mesa (master): zink: document requirement of VK_EXT_custom_border_color
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Apr 19 19:44:01 UTC 2021
Module: Mesa
Branch: master
Commit: ff007afce252548f797be180fd8719ed8d6a2db0
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff007afce252548f797be180fd8719ed8d6a2db0
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Apr 19 12:41:01 2021 +0200
zink: document requirement of VK_EXT_custom_border_color
Without this extension, we misrender when custom border colors are
used. Let's document this, and emit a warning when the extension is
missing.
Reviewed-by: Joshua Ashton <joshua at froggi.es>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10316>
---
docs/drivers/zink.rst | 1 +
src/gallium/drivers/zink/zink_screen.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/drivers/zink.rst b/docs/drivers/zink.rst
index c5203679db5..a4911394c2b 100644
--- a/docs/drivers/zink.rst
+++ b/docs/drivers/zink.rst
@@ -37,6 +37,7 @@ Here's a list of those requirements:
* Device extensions:
* `VK_KHR_maintenance1`_
+ * `VK_EXT_custom_border_color`
In addition to this, `VK_KHR_external_memory`_ is required to support the
DRI code-path.
diff --git a/src/gallium/drivers/zink/zink_screen.c b/src/gallium/drivers/zink/zink_screen.c
index 267695b0323..40a46e9eae3 100644
--- a/src/gallium/drivers/zink/zink_screen.c
+++ b/src/gallium/drivers/zink/zink_screen.c
@@ -1432,7 +1432,8 @@ check_base_requirements(struct zink_screen *screen)
!screen->info.feats.features.shaderClipDistance ||
!(screen->info.feats12.scalarBlockLayout ||
screen->info.have_EXT_scalar_block_layout) ||
- !screen->info.have_KHR_maintenance1) {
+ !screen->info.have_KHR_maintenance1 ||
+ !screen->info.have_EXT_custom_border_color) {
fprintf(stderr, "WARNING: The Vulkan device doesn't support "
"the base Zink requirements, some incorrect rendering "
"might occur\n");
More information about the mesa-commit
mailing list