Mesa (master): intel/compiler: Fix INTEL_DEBUG=hex

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Apr 30 09:30:40 UTC 2021


Module: Mesa
Branch: master
Commit: 3f04383521d59ec5716ba4a81db7b97086914573
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f04383521d59ec5716ba4a81db7b97086914573

Author: Jordan Justen <jordan.l.justen at intel.com>
Date:   Thu Apr 29 15:12:10 2021 -0700

intel/compiler: Fix INTEL_DEBUG=hex

With the missing else, this prints the compacted hex followed by hex
for an uncompacted version of the compacted instruction. It also
doesn't print hex for instructions that are not compacted.

Fixes: bc4a127d6e1 ("intel/disasm: Label support in shader disassembly for UIP/JIP")
Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4245
Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10535>

---

 src/intel/compiler/brw_eu.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/intel/compiler/brw_eu.cpp b/src/intel/compiler/brw_eu.cpp
index 2536ab0fc3c..22683890ca4 100644
--- a/src/intel/compiler/brw_eu.cpp
+++ b/src/intel/compiler/brw_eu.cpp
@@ -566,6 +566,7 @@ brw_disassemble(const struct intel_device_info *devinfo,
 
          brw_uncompact_instruction(devinfo, &uncompacted, compacted);
          insn = &uncompacted;
+      } else {
          if (dump_hex) {
             unsigned char * insn_ptr = ((unsigned char *)&insn[0]);
             for (int i = 0 ; i < 16; i = i + 4) {



More information about the mesa-commit mailing list