Mesa (main): ac/nir: Remove unhelpful nir_opt_cse from ac_nir_lower_ngg_nogs.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: a6110f3c3aad6e73523040bb71f60c1b4a3209ee
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a6110f3c3aad6e73523040bb71f60c1b4a3209ee

Author: Timur Kristóf <timur.kristof at gmail.com>
Date:   Thu Jul 15 15:28:13 2021 +0200

ac/nir: Remove unhelpful nir_opt_cse from ac_nir_lower_ngg_nogs.

This CSE call adds to our compile time without adding any real
benefit to the compiled code.

Fossil DB results on Sienna Cichlid (with NGGC on):

Totals from 1580 (1.23% of 128647) affected shaders:
CodeSize: 4563912 -> 4562312 (-0.04%); split: -0.07%, +0.03%
Instrs: 870722 -> 870338 (-0.04%); split: -0.09%, +0.04%
Latency: 3349863 -> 3351458 (+0.05%); split: -0.10%, +0.14%
InvThroughput: 617796 -> 617971 (+0.03%); split: -0.01%, +0.03%
VClause: 22604 -> 22568 (-0.16%); split: -0.75%, +0.59%
SClause: 16285 -> 16327 (+0.26%); split: -0.07%, +0.33%
Copies: 83472 -> 83599 (+0.15%); split: -0.07%, +0.22%
PreSGPRs: 62340 -> 62334 (-0.01%)

No Fossil DB changes with NGGC off.

Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11908>

---

 src/amd/common/ac_nir_lower_ngg.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/common/ac_nir_lower_ngg.c b/src/amd/common/ac_nir_lower_ngg.c
index 0afb43900d7..75728b707f3 100644
--- a/src/amd/common/ac_nir_lower_ngg.c
+++ b/src/amd/common/ac_nir_lower_ngg.c
@@ -1265,7 +1265,6 @@ ac_nir_lower_ngg_nogs(nir_shader *shader,
    do {
       progress = false;
       NIR_PASS(progress, shader, nir_opt_undef);
-      NIR_PASS(progress, shader, nir_opt_cse);
       NIR_PASS(progress, shader, nir_opt_dce);
       NIR_PASS(progress, shader, nir_opt_dead_cf);
    } while (progress);