Mesa (staging/21.1): 36 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Aug 4 21:36:02 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4573be21ca1d10ac650a437c7d3547eebf8145ae
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Jul 19 05:58:48 2021 +1000
virgl: disable anisotropic filtering.
virgl doesn't yet support anisotropic filtering so don't advertise it.
Fixes: a8987b88ff1d ("virgl: add driver for virtio-gpu 3D (v2)")
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11944>
(cherry picked from commit e831c4a537cc4118ba6d5581dfc121a9fe47110a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=45f6e2a38ff3787b8f9902566651ce98847d59cb
Author: Pierre Moreau <dev at pmoreau.org>
Date: Sun Apr 25 21:59:27 2021 +0200
clover/nir: Set constant buffer pointer size to host
The `argument::size` is supposed to represent the size of a pointer on
the host and not on the device (for which argument::target_size`
exists).
v3: Use `sizeof(buf)` instead of `marg.size`. (Francisco Jerez)
Fixes: 7c6f1d3bf99 ("clover/nir: extract constant buffer into its own section")
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
Signed-off-by: Pierre Moreau <dev at pmoreau.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10256>
(cherry picked from commit b4e5bf0637e10d0f7c191d4772f06d0432d87415)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=079a63ad582490bf6759fad9f7a8bc4542208355
Author: Pierre Moreau <dev at pmoreau.org>
Date: Tue Apr 13 22:14:03 2021 +0200
clover/spirv: Properly size 3-component vector args
This resolves clover returning `CL_INVALID_ARG_SIZE` whenever the OpenCL
CTS called `clSetKernelArg()` for 3-component vectors.
Fixes: 21473865050 ("clover/spirv: Add functions for parsing arguments, linking programs, etc.")
v2: Remove “api/clsetkernelarg/set kernel argument for cl_int3” from the
expected fails for llvmpipe
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Signed-off-by: Pierre Moreau <dev at pmoreau.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10256>
(cherry picked from commit a6c26a6ad94d16ad044c3b64d72ff9daf863b3be)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=68a9d9f681540ab8a16d16930b77369498f61c50
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Tue Aug 3 13:05:23 2021 +0200
gallium/hud: initialize query
Most of the drivers don't set up the maximum value in the query info. So
when later hud_pane_set_max_value() is invoked, we are using a rather
"random" number.
Turns out that in some 32bit cases, this random number is big enough
that `leftmost_digit` is 0 because DIV_ROUND_UP() overflows, aborting
with an assertion.
Fixes: c91cf7d7d2c ("gallium: implement a heads-up display module")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12181>
(cherry picked from commit 10541d1fade07e57441b591a36b0bf02f5eca299)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1149be368aa30f002ad708212c32d0f0cb6ce7fe
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Aug 2 14:27:11 2021 +0200
radv: fix selecting the first active CU when profiling with SQTT
Fixes: d26bcc0f5cb ("radv: always select the first active CU when profiling with SQTT")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12167>
(cherry picked from commit ebea075feb820fb4e2118690da8258aa830ba3a3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8df9e422da67eee15345e0b61b15efa559fbea4
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Thu Jul 29 12:14:16 2021 +1000
intel/compiler: make sure swizzle is applied to if condition
This fixes a hang in the following piglit test when GCM moves a
UBO load outside of the loop.
tests/shaders/ssa/fs-if-def-else-break.shader_test
The end NIR ends up looking like this:
vec2 32 ssa_3 = intrinsic load_ubo (ssa_2, ssa_0) (0, 1073741824, 0, 0, 8)
vec1 32 ssa_4 = mov ssa_3.x
vec1 32 ssa_5 = inot ssa_3.y
/* succs: block_1 */
loop {
...
if ssa_5 { }
}
Fixes: 1edf67fc3f6b ("intel/fs: Generate if instructions with inverted conditions")
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12064>
(cherry picked from commit a654e39f1559edc06eb12bdd6f2372694dcd8911)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=087c7a309337aefed31bf9f51ed1cf19aefb6526
Author: Icecream95 <ixn at disroot.org>
Date: Thu Jul 22 20:17:31 2021 +1200
pan/mdg: Analyze helper termination after scheduling
Similar to the fix in 6bf8e960faa ("pan/bi: Do helper termination
analysis on clauses")
Though apparently a "theoretical issue only", fixes artefacts in
DarkPlaces with both D3D9 and GL renderers.
Fixes: 9a7f0e268b7 ("pan/mdg: Use the helper invo analyze passes")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12156>
(cherry picked from commit a2b37e95926f52b597dd0cf440092bd296efa434)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0fc1e293ad524eb78e88be8835ef34df721c490f
Author: Hoe Hao Cheng <haochengho12907 at gmail.com>
Date: Fri Jul 30 16:59:21 2021 +0800
zink: make codegen compatible with python 3.5
Fixes: f1432fd3 ("zink: generate extension infrastructure using a python script")
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12137>
(cherry picked from commit 86250c7251b5652acc794a8b0efe2ad98cfec840)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=329df0b83053aab5836e46ad08a3907bd730af5a
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Mon Jul 26 10:47:20 2021 +0200
amd/registers: fix fields conflict detection
The existing code handled the case where the new definition of the
same field was larger than the old one.
This commit adds a check to handle the reverse case: the new def
is smaller than the old one (= so writing using the merged macro
would affect the next fields).
The affected fields are:
* LGKM_CNT (in SQ_WAVE_IB_STS)
* DONUT_SPLIT (in VGT_TESS_DISTRIBUTION)
* HEAD_QUEUE (in GDS_GWS_RESOURCE)
DONUT_SPLIT is the only one used by radeonsi/radv.
Fixes: e6184b08924 ("amd/registers: scripts for processing register descriptions in JSON")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12063>
(cherry picked from commit 3914bd457b6e91c805a6ed9977ed984205f8acae)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=441bcc13a3aebfb129e2b9d5bdaf67b8dba62640
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Mon Jul 26 15:47:24 2021 +0200
gallium/va: don't use key=NULL in hash tables
Add 1 to the key index otherwise we hit the following assert
in hash_table_insert:
assert(!key_pointer_is_reserved(ht, key));
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12105>
(cherry picked from commit 2ea88d7cea070c3288c252064cae9236bd462646)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f3afadaf609faa69ac90f95b8fcb3ad69dc177d
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Jul 28 13:51:38 2021 +1000
intel/fs: restrict max push length on older GPUs to a smaller amount
Fixes crash in dEQP-GLES2.functional.uniform_api.random.79
Cc: mesa-stable
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12093>
(cherry picked from commit c8783001c7350960a63bff0dc93a4e744c22b911)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9817ce82466b16a4c1e44067e1e57b9ed21086b3
Author: Joshua Watt <JPEWhacker at gmail.com>
Date: Tue Jul 27 11:41:53 2021 -0500
v3d, vc4: Fix dmabuf import for non-scanout buffers
Failure to create a buffer for scanout should not be fatal when
importing a buffer. Buffers allocated from a render-only device may not
be able to scanned out directly but can still be used for other
rendering purposes (e.g. as a texture).
Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
Reviewed-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12081>
(cherry picked from commit 7bcb22363935431f1c8886608d9a77b3503fc5b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6b000ad797b6724806fb235a6443ee490e4cfe7
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Thu Jul 29 14:26:08 2021 -0400
pan/bi: Restrict swizzles on same cycle temporaries
Hand typed. We could generate this from the XML to avoid the repititon
but I think the cure is worse than the disease.
This fixes instruction encoding faults seen in conformance tests.
Only a single shader-db affected, and it was likely already broken...
quadwords HURT: shaders/glmark/22-1.shader_test MESA_SHADER_FRAGMENT: 133 -> 135 (1.50%)
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12114>
(cherry picked from commit 2cdf95703a816f9dfe4a2bc282caee21ddd94970)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3a453c1014c90ecee4e71afff7796e3c0e0e3a17
Author: Simon Ser <contact at emersion.fr>
Date: Tue Jul 27 09:04:14 2021 +0200
lima: fail in get_handle(TYPE_KMS) without a scanout resource
The previous logic was returning a handle valid for the render-only
device if rsc->scanout was NULL. However the caller doesn't expect
this: the caller will use the handle with the KMS device.
Instead of returning a handle for the wrong device, fail if we don't
have one.
Signed-off-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Vasily Khoruzhick <anarsoul at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12074>
(cherry picked from commit 47f000c170ccb824b308e02db8c2c955a8c00217)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1ea46c2564344cd14e58e4ee03fab4e4aad3e3ae
Author: Simon Ser <contact at emersion.fr>
Date: Tue Jul 27 08:59:52 2021 +0200
panfrost: fail in get_handle(TYPE_KMS) without a scanout resource
The previous logic was returning a handle valid for the render-only
device if rsc->scanout was NULL. However the caller doesn't expect
this: the caller will use the handle with the KMS device.
Instead of returning a handle for the wrong device, fail if we don't
have one.
Signed-off-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Daniel Stone <daniels at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12074>
(cherry picked from commit 4c092947df308f20e288bb5baf50bff181e5d3fa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e75103a99c30925a52cf03155a269a7a3e239df6
Author: Simon Ser <contact at emersion.fr>
Date: Tue Jul 27 08:59:09 2021 +0200
freedreno: fail in get_handle(TYPE_KMS) without a scanout resource
The previous logic was returning a handle valid for the render-only
device if rsc->scanout was NULL. However the caller doesn't expect
this: the caller will use the handle with the KMS device.
Instead of returning a handle for the wrong device, fail if we don't
have one.
Signed-off-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Emma Anholt <emma at anholt.net>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12074>
(cherry picked from commit 465eb7864bf0328aa2d497f0c2a2de72fafeced6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc5e91d38a70c232505140bf79df974db6e7d27f
Author: Simon Ser <contact at emersion.fr>
Date: Tue Jul 27 08:55:02 2021 +0200
etnaviv: fail in get_handle(TYPE_KMS) without a scanout resource
The previous logic was returning a handle valid for the render-only
device if rsc->scanout was NULL. However the caller doesn't expect
this: the caller will use the handle with the KMS device.
Instead of returning a handle for the wrong device, fail if we don't
have one.
Signed-off-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12074>
(cherry picked from commit 9da901d2b2e7ab5d5f21a0004fc294810f69f04a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=193e167dcadc679cc6c653727c978e33d89003b9
Author: Simon Ser <contact at emersion.fr>
Date: Tue Jul 27 08:52:45 2021 +0200
etnaviv: fix renderonly check in etna_resource_alloc
When the driver hasn't been initialized via renderonly, screen->ro
will be NULL. This fixes a crash when passing USE_SCANOUT to etnaviv
when it's missing renderonly.
Signed-off-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12074>
(cherry picked from commit 3b3cd5128672ab2dd2541b1789a40a4dd2652cc1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=904ec5b0f1d52b5074c62d0544989526b3af2050
Author: Thomas H.P. Andersen <phomes at gmail.com>
Date: Wed Jul 14 14:51:26 2021 +0200
nine: Fix assert in tx_src_param
A previous commit cleaned up the asserts but the last part of
this assert looks like it got mixed up. It should have allowed
param->rel for D3DSPR_INPUT if version is 3.0. Instead it does
&& on the enum value D3DSPR_ADDR which is of course always true,
with the version check. The result is that we miss input
validation with version 3.0.
Spotted by a compile warning
Fixes: 5974401a4ad ("st/nine: Regroup param->rel tests")
Reviewed-by: Axel Davy davyaxel0 at gmail.com
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11880>
(cherry picked from commit 71a5bcb8658491dd62b9e620a9ce7f3bf7c8952b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c8e65b1c2dad1ada5866d7e562fa5d94b7ff162
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Jul 28 18:44:07 2021 +0300
anv: fix submission batching with perf queries
If we have 2 command buffers back to back, one with a query pool, one
without, we don't want to retain the second query pool value (NULL).
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 0a7224f3ff7542 ("anv: group as many command buffers into a single execbuf")
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12107>
(cherry picked from commit b8e29e89366a5264391dc7c10e778330b7add66a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=935fbbe386048ac301c30539d34412c39e3819b2
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Jul 27 12:01:36 2021 -0700
freedreno/ir3: Add build id to the disassembler test
This is required (at least for me on x86) to get the tool to pass it's
own test, otherwise it fails the build_id assertion.
Fixes: 1462b00391711ff86350e802c1a3e5075a3a1632
("freedreno/ir3: Add a unit test for our disassembler.")
Acked-by: Rob Clark <robclark at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12084>
(cherry picked from commit 097cf3952bff22e7132ab4eb804f4ea14d61a8d4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a638757224fb6f5b242f297750605dd9aba9e8db
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Wed Jul 21 10:30:26 2021 -0700
mesa/main: Check for fbo attachments when importing EGL images to textures
Fixes an assert when binding an fbo with a texture bound to one of its attachments,
if the texture was updated with an EGL image after it was bound.
Cc: mesa-stable
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11998>
(cherry picked from commit 3d64a97cf694a8f36d2a285a83b30c2558aac334)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=66e1a120aecf015e2d04c7aca7d6082d088735e0
Author: Connor Abbott <cwabbott0 at gmail.com>
Date: Wed Jul 28 16:35:48 2021 +0200
ir3: Preserve gl_ViewportIndex in the binning shader
Fixes dEQP-VK.draw.shader_viewport_index.* with TU_DEBUG=forcebin.
Fixes: efff7342204 ("turnip: multiViewport and VK_EXT_shader_viewport_index_layer")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12104>
(cherry picked from commit 7a14484bca7619e016b9b901637ee3172b9dca70)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd85f0ce66e8dfc7ed17013c9675074c10d0e9a9
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Sat Jul 17 17:38:42 2021 +0300
loader/dri3: create linear buffer with scanout support
If we have a different GPU dealing with display, we fallback to
exchanging linear buffers with the compositor. We should specify in
creating the linear buffer that this could be used for display.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4706
Cc: mesa-stable
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11942>
(cherry picked from commit f1a66e7c90ceb4796085989d0d8374689753121e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=053fd9671cc9a3d9faf37f7a4dbdb4cf589c9c48
Author: Zhu Yuliang <zhuyuliang at uniontech.com>
Date: Wed Jul 28 11:27:27 2021 +0800
gallium/vl: don't leak fd in vl_dri3_screen_create
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12092>
(cherry picked from commit b88fd3ccc0deeb3776ed4fd0c72b4ab649e1a208)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f74ed3862e5c8d2fca21a5b4c90d594834dc0dfd
Author: Chia-I Wu <olvaffe at gmail.com>
Date: Thu Jul 22 16:52:47 2021 -0700
vulkan/wsi/x11: do not inherit last_present_mode
Under XWayland, the first present after a window resize is sometimes
completed with COPY (seems to happen when the previous present with the
old size is pending; not really sure). The following presents are
completed with FLIP.
When a swapchain is created with an old swapchain, and
old_chain->last_present_mode is FLIP, chain->last_present_mode is set to
FLIP as well. This causes the new swapchain to be marked
VK_SUBOPTIMAL_KHR, which is sticky, if the first present is completed
with COPY.
Instead of inheriting, treat each swapchain as independent. We will
miss the case where an old swapchain is flipping but a new swapchain is
copying. But swapchain reallocation normally happens in response to
present engine state change. If the newly allocated swapchain is
copying, another reallocation is unlikely to fix that.
Fixes: 61309c2a727 ("vulkan/wsi/x11: Return VK_SUBOPTIMAL_KHR for X11")
Signed-off-by: Chia-I Wu <olvaffe at gmail.com>
Reviewed-by: Louis-Francis Ratté-Boulianne <lfrb at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12030>
(cherry picked from commit 206fe780d509b3e0814c52bf15765a0de33743bf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=33cd7e51ae24718d49b76927d869f020a8323cb0
Author: Philipp Zabel <p.zabel at pengutronix.de>
Date: Thu Jul 22 12:47:15 2021 +0200
etnaviv: fix gbm_bo_get_handle_for_plane for multiplanar images
Implement resource_get_param for PIPE_RESOURCE_PARAM_NPLANES and fix
resource_get_handle to walk to the correct linked resource for
multiplanar images, allowing gbm_bo_get_handle_for_plane to be called
with plane > 0.
This fixes an assert that is triggered when a wayland client tries
to send weston an NV12 dmabuf, for example:
weston: .../mesa/src/gbm/backends/dri/gbm_dri.c:752: gbm_dri_bo_get_handle_for_plane: Assertion `plane == 0' failed.
Fixes: 788f6dc85781 ('Revert "gallium/dri: fix dri2_from_planar for multiplanar images"')
Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12037>
(cherry picked from commit 8ba44103b31d90b0c7531d66aa74254412485c85)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cac3414a05b94627163ff6dad793c590083e0cb
Author: Lepton Wu <lepton at chromium.org>
Date: Fri Jul 23 21:27:00 2021 -0700
gallium: Reset {d,r}Priv in dri_unbind_context
The code in dri_make_current just checks the value of the pointers
to decide to update texture_stamp or not. This is buggy since a new
allocated drawable could share the same address with the previous
released drawable. Fix the stale pointer issue by always resetting
these pointers to NULL in dri_unbind_context.
v2:
Move the reset codes to the end of the function.
Signed-off-by: Lepton Wu <lepton at chromium.org>
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12050>
(cherry picked from commit 7ff30a0499bd872d77b0f377414bbc03463b9f87)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0e56b32d1151a80b47c0190074222387a2daf98
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date: Wed Jul 14 20:52:56 2021 +0300
glsl: Properly handle .length() of an unsized array
There are two distinct cases:
- The last member of a shader storage block (length determined at run-time)
- Implicitly-sized array (length determined at link-time)
Fixes: 273f61a0051a ("glsl: Add parser/compiler support for unsized array's length()")
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11952>
(cherry picked from commit c3f47f6e300ef1ec18b2c55ec82bccf263292351)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=981d7b949bee8cf3f74b7e1bc80b0277c1acf4d7
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date: Wed Jul 14 20:39:45 2021 +0300
glsl: Add operator for .length() method on implicitly-sized arrays
ARB_shader_storage_buffer_object extension (promoted to core in 4.3) allows us
to call .length() method on arrays declared without an explicit size. The length is
determined at link time as a maximum array access.
Fixes: 273f61a0051a ("glsl: Add parser/compiler support for unsized array's length()")
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11952>
(cherry picked from commit 441826aaaac54e84629269c4622be2f17a465209)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9ae98da3ba25cd50fec796cd80d282c38d25e903
Author: Erico Nunes <nunes.erico at gmail.com>
Date: Sun Jul 25 13:48:59 2021 +0200
lima: avoid crash with negative viewport values
The viewport value computations done in lima_set_viewport_states
can result in a negative value for viewport.
These could end up converted to unsigned values in
lima_clip_scissor_to_viewport causing crashes from invalid
scissor commands.
Prevent this by limiting the minimum value to zero as is already
done for the left and bottom values.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2938
Cc: mesa-stable
Signed-off-by: Erico Nunes <nunes.erico at gmail.com>
Reviewed-by: Vasily Khoruzhick <anarsoul at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12055>
(cherry picked from commit e6cdb01c517b42dece9ed532fd6eba7a74aa8f71)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c49228faa7f3e82621835d63e763fe661354de8f
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jul 26 13:11:18 2021 -0400
zink: use array size in spirv bo length calculations
I don't know why I was dropping this, but doing so breaks drivers that have
optimization passes based on the lengths of these variables
Fixes: c1cdf30a119 ("zink: apply Delete All The Code methodology to the ubo/ssbo variables")
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12070>
(cherry picked from commit 1dc7b9b08b6a272693f85e956ec3c4e498823a65)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6bc6807d7bcf18c8840ee36f19734ad0747abfd5
Author: Karol Herbst <kherbst at redhat.com>
Date: Sun Jul 25 02:10:29 2021 +0200
nv30: fix emulated vertex index buffers
We ended up applying the offset twice. Quite embarrassing.
This fixes a bunch of vertex shader related issues like the gnome desktop
is less broken and probably a lot of other applications.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5061
Cc: mesa-stable
Signed-off-by: Karol Herbst <kherbst at redhat.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12054>
(cherry picked from commit 1387d1d41103b3120d40f93f66a7cfe00304bfd7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e252c23519478c47effa4eb7c0bd2f8a342bd579
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jul 9 11:34:23 2021 -0500
nir/lower_tex: Rework invalid implicit LOD lowering
Only fragment and some compute shaders support implicit derivatives.
They're totally meaningless without helper invocations and some
understanding of the dispatch pattern. We've got code to lower
nir_texop_tex in these shader stages to use an explicit derivative of 0
but it was pretty badly broken:
1. It only handled nir_texop_tex, not nir_texop_txb or nir_texop_lod.
2. It didn't take min_lod into account
3. It was conflated with adding a missing LOD parameter to opcodes
which expect one such as nir_texop_txf. While not really a bug,
this does make it way harder to reason about the code.
4. Unless you set a flag (which most drivers don't), it left the
opcode nir_texop_tex instead of nir_texop_txl which it should have
been.
This reworks it to go through roughly the same path as other LOD
lowering only with a constant lod of 0 instead of calling out to
nir_texop_lod. We also get rid of the lower_tex_without_implicit_lod
flag because most drivers set it and those that don't are probably
subtly broken. If someone really wants to get nir_texop_tex in their
vertex shaders, they can write a new patch to add the flag back in.
Fixes: e382890e25c0 "nir: set default lod to texture opcodes that..."
Fixes: d5ac5d6e836f "nir: Add option to lower tex to txl when..."
Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11775>
(cherry picked from commit 74ec2b12be17a7796186b3100a5a6b208be45b23)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc90d8cc144b6c665df78d61f0b638f6c8c121db
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Jul 23 16:22:33 2021 +1000
teximage: return correct desktop GL error for compressedteximage
For GL4.6 the spec says to return GL_INVALID_OPERATION for this.
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12032>
(cherry picked from commit 2138d1b9e630b4c481c9d1ff555fb77a71ef78cc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b40e6831411c2fa553a34f83027f9d493615141b
Author: Eric Engestrom <eric at engestrom.ch>
Date: Wed Aug 4 22:18:54 2021 +0100
.pick_status.json: Update to 7055282231cdad23e7b23fb49a2f953a99797f8a
More information about the mesa-commit
mailing list