Mesa (staging/21.1): anv: don't try to access Android swapchains
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Aug 9 07:32:38 UTC 2021
Module: Mesa
Branch: staging/21.1
Commit: 7c0e37e1029a305e52387d175088dc903fc3155d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c0e37e1029a305e52387d175088dc903fc3155d
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Aug 5 18:10:15 2021 +0300
anv: don't try to access Android swapchains
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5180
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12217>
(cherry picked from commit bc3c71b87ae0b8e053f45c26c1179560e462db04)
---
.pick_status.json | 2 +-
src/intel/vulkan/anv_image.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/.pick_status.json b/.pick_status.json
index ca3efdb325e..421d5bdfbc2 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -580,7 +580,7 @@
"description": "anv: don't try to access Android swapchains",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index b99891a4fcd..c1f4898b5ce 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -1477,11 +1477,17 @@ anv_CreateImage(VkDevice device,
return anv_image_from_gralloc(device, pCreateInfo, gralloc_info,
pAllocator, pImage);
+#ifndef VK_USE_PLATFORM_ANDROID_KHR
+ /* Ignore swapchain creation info on Android. Since we don't have an
+ * implementation in Mesa, we're guaranteed to access an Android object
+ * incorrectly.
+ */
const VkImageSwapchainCreateInfoKHR *swapchain_info =
vk_find_struct_const(pCreateInfo->pNext, IMAGE_SWAPCHAIN_CREATE_INFO_KHR);
if (swapchain_info && swapchain_info->swapchain != VK_NULL_HANDLE)
return anv_image_from_swapchain(device, pCreateInfo, swapchain_info,
pAllocator, pImage);
+#endif
return anv_image_create(device,
&(struct anv_image_create_info) {
More information about the mesa-commit
mailing list