Mesa (main): radv: allow DCC MSAA fast clears if a FCE is needed

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Aug 9 10:10:55 UTC 2021


Module: Mesa
Branch: main
Commit: ade66c1aeb5e1076d0c3937f369b19bf5762e8c1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ade66c1aeb5e1076d0c3937f369b19bf5762e8c1

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Aug  3 11:37:29 2021 +0200

radv: allow DCC MSAA fast clears if a FCE is needed

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12180>

---

 src/amd/vulkan/radv_meta_clear.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
index 65543c0fdf9..89a3f16d3f2 100644
--- a/src/amd/vulkan/radv_meta_clear.c
+++ b/src/amd/vulkan/radv_meta_clear.c
@@ -1548,18 +1548,6 @@ radv_can_fast_clear_color(struct radv_cmd_buffer *cmd_buffer, const struct radv_
       vi_get_fast_clear_parameters(cmd_buffer->device, iview->image->vk_format, iview->vk_format,
                                    &clear_value, &reset_value, &can_avoid_fast_clear_elim);
 
-      if (iview->image->info.samples > 1) {
-         /* DCC fast clear with MSAA should clear CMASK. */
-         /* FIXME: This doesn't work for now. There is a
-          * hardware bug with fast clears and DCC for MSAA
-          * textures. AMDVLK has a workaround but it doesn't
-          * seem to work here. Note that we might emit useless
-          * CB flushes but that shouldn't matter.
-          */
-         if (!can_avoid_fast_clear_elim)
-            return false;
-      }
-
       if (iview->image->info.levels > 1) {
          if (cmd_buffer->device->physical_device->rad_info.chip_class >= GFX9) {
             uint32_t last_level = iview->base_mip + iview->level_count - 1;



More information about the mesa-commit mailing list