Mesa (main): anv: Rename anv_get_format_plane to anv_get_format_aspect

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Aug 9 16:19:12 UTC 2021


Module: Mesa
Branch: main
Commit: 4518ae82845c88b37f30e7a118a3ef9ef26061c1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4518ae82845c88b37f30e7a118a3ef9ef26061c1

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Fri Jul 30 06:31:03 2021 -0500

anv: Rename anv_get_format_plane to anv_get_format_aspect

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12141>

---

 src/intel/vulkan/anv_blorp.c   | 12 ++++++------
 src/intel/vulkan/anv_formats.c | 16 ++++++++--------
 src/intel/vulkan/anv_image.c   |  8 ++++----
 src/intel/vulkan/anv_private.h |  8 ++++----
 4 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 7e53ee6ddac..52f7a98cf7a 100644
--- a/src/intel/vulkan/anv_blorp.c
+++ b/src/intel/vulkan/anv_blorp.c
@@ -689,11 +689,11 @@ blit_image(struct anv_cmd_buffer *cmd_buffer,
                                    dst_image_layout, ISL_AUX_USAGE_NONE, &dst);
 
       struct anv_format_plane src_format =
-         anv_get_format_plane(&cmd_buffer->device->info, src_image->vk_format,
-                              1U << aspect_bit, src_image->tiling);
+         anv_get_format_aspect(&cmd_buffer->device->info, src_image->vk_format,
+                               1U << aspect_bit, src_image->tiling);
       struct anv_format_plane dst_format =
-         anv_get_format_plane(&cmd_buffer->device->info, dst_image->vk_format,
-                              1U << aspect_bit, dst_image->tiling);
+         anv_get_format_aspect(&cmd_buffer->device->info, dst_image->vk_format,
+                               1U << aspect_bit, dst_image->tiling);
 
       unsigned dst_start, dst_end;
       if (dst_image->type == VK_IMAGE_TYPE_3D) {
@@ -1031,8 +1031,8 @@ void anv_CmdClearColorImage(
                                    imageLayout, ISL_AUX_USAGE_NONE, &surf);
 
       struct anv_format_plane src_format =
-         anv_get_format_plane(&cmd_buffer->device->info, image->vk_format,
-                              VK_IMAGE_ASPECT_COLOR_BIT, image->tiling);
+         anv_get_format_aspect(&cmd_buffer->device->info, image->vk_format,
+                               VK_IMAGE_ASPECT_COLOR_BIT, image->tiling);
 
       unsigned base_layer = pRanges[r].baseArrayLayer;
       unsigned layer_count = anv_get_layerCount(image, &pRanges[r]);
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index abc8184c6fd..b77871b9b4e 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -468,9 +468,9 @@ anv_format_has_npot_plane(const struct anv_format *anv_format) {
  * _cannot_ check for compatibility).
  */
 struct anv_format_plane
-anv_get_format_plane(const struct intel_device_info *devinfo,
-                     VkFormat vk_format,
-                     VkImageAspectFlagBits aspect, VkImageTiling tiling)
+anv_get_format_aspect(const struct intel_device_info *devinfo,
+                      VkFormat vk_format,
+                      VkImageAspectFlagBits aspect, VkImageTiling tiling)
 {
    const struct anv_format *format = anv_get_format(vk_format);
    const struct anv_format_plane unsupported = {
@@ -581,17 +581,17 @@ anv_get_image_format_features(const struct intel_device_info *devinfo,
    }
 
    const struct anv_format_plane plane_format =
-      anv_get_format_plane(devinfo, vk_format, VK_IMAGE_ASPECT_COLOR_BIT,
-                           vk_tiling);
+      anv_get_format_aspect(devinfo, vk_format, VK_IMAGE_ASPECT_COLOR_BIT,
+                            vk_tiling);
 
    if (plane_format.isl_format == ISL_FORMAT_UNSUPPORTED)
       return 0;
 
    struct anv_format_plane base_plane_format = plane_format;
    if (vk_tiling != VK_IMAGE_TILING_LINEAR) {
-      base_plane_format = anv_get_format_plane(devinfo, vk_format,
-                                               VK_IMAGE_ASPECT_COLOR_BIT,
-                                               VK_IMAGE_TILING_LINEAR);
+      base_plane_format = anv_get_format_aspect(devinfo, vk_format,
+                                                VK_IMAGE_ASPECT_COLOR_BIT,
+                                                VK_IMAGE_TILING_LINEAR);
    }
 
    enum isl_format base_isl_format = base_plane_format.isl_format;
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index bd5305b8758..0d0d3e60e38 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -1035,7 +1035,7 @@ add_all_surfaces_implicit_layout(
       VkImageAspectFlagBits aspect = 1 << b;
       uint32_t plane = anv_image_aspect_to_plane(image->aspects, aspect);
       const  struct anv_format_plane plane_format =
-         anv_get_format_plane(devinfo, image->vk_format, aspect, image->tiling);
+         anv_get_format_aspect(devinfo, image->vk_format, aspect, image->tiling);
 
       VkImageUsageFlags vk_usage = image->usage;
       if (aspect == VK_IMAGE_ASPECT_STENCIL_BIT)
@@ -1156,7 +1156,7 @@ add_all_surfaces_explicit_layout(
       const VkImageAspectFlagBits aspect = 1 << b;
       const uint32_t plane = anv_image_aspect_to_plane(image->aspects, aspect);
       const struct anv_format_plane format_plane =
-         anv_get_format_plane(devinfo, image->vk_format, aspect, image->tiling);
+         anv_get_format_aspect(devinfo, image->vk_format, aspect, image->tiling);
       const VkSubresourceLayout *primary_layout = &drm_info->pPlaneLayouts[plane];
 
       result = add_primary_surface(device, image, plane,
@@ -2819,8 +2819,8 @@ anv_CreateImageView(VkDevice _device,
       VkImageAspectFlags vplane_aspect =
          anv_plane_to_aspect(iview->aspect_mask, vplane);
       struct anv_format_plane format =
-         anv_get_format_plane(&device->info, iview->vk_format,
-                              vplane_aspect, image->tiling);
+         anv_get_format_aspect(&device->info, iview->vk_format,
+                               vplane_aspect, image->tiling);
 
       iview->planes[vplane].image_plane = iplane;
 
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index b5180910dbe..7db2bfdd4de 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -3839,15 +3839,15 @@ anv_get_format_planes(VkFormat vk_format)
 }
 
 struct anv_format_plane
-anv_get_format_plane(const struct intel_device_info *devinfo,
-                     VkFormat vk_format,
-                     VkImageAspectFlagBits aspect, VkImageTiling tiling);
+anv_get_format_aspect(const struct intel_device_info *devinfo,
+                      VkFormat vk_format,
+                      VkImageAspectFlagBits aspect, VkImageTiling tiling);
 
 static inline enum isl_format
 anv_get_isl_format(const struct intel_device_info *devinfo, VkFormat vk_format,
                    VkImageAspectFlags aspect, VkImageTiling tiling)
 {
-   return anv_get_format_plane(devinfo, vk_format, aspect, tiling).isl_format;
+   return anv_get_format_aspect(devinfo, vk_format, aspect, tiling).isl_format;
 }
 
 bool anv_formats_ccs_e_compatible(const struct intel_device_info *devinfo,



More information about the mesa-commit mailing list