Mesa (staging/21.1): pick-ui: drop assert that optional argument is passed

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 10 21:42:10 UTC 2021


Module: Mesa
Branch: staging/21.1
Commit: 7eaf0b6697ff68ab680d6ae2256ccf07cbe52bd5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7eaf0b6697ff68ab680d6ae2256ccf07cbe52bd5

Author: Eric Engestrom <eric at engestrom.ch>
Date:   Wed Apr 29 18:51:30 2020 +0200

pick-ui: drop assert that optional argument is passed

Let's just make it not-optional instead.

Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12289>
(cherry picked from commit db14f2a9326a3dfefd2abbf937641f7ab92024a2)

---

 .pick_status.json | 2 +-
 bin/pick/ui.py    | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.pick_status.json b/.pick_status.json
index 0abd1a9dd45..df0c8b975b4 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -22,7 +22,7 @@
         "description": "pick-ui: drop assert that optional argument is passed",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": null
     },
diff --git a/bin/pick/ui.py b/bin/pick/ui.py
index 3afd05e0ca2..3337d7dbd26 100644
--- a/bin/pick/ui.py
+++ b/bin/pick/ui.py
@@ -43,9 +43,8 @@ PALETTE = [
 
 class RootWidget(urwid.Frame):
 
-    def __init__(self, *args, ui: 'UI' = None, **kwargs):
+    def __init__(self, *args, ui: 'UI', **kwargs):
         super().__init__(*args, **kwargs)
-        assert ui is not None
         self.ui = ui
 
     def keypress(self, size: int, key: str) -> typing.Optional[str]:



More information about the mesa-commit mailing list