Mesa (main): iris: don't bump the seqno for the workaround_bo

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Aug 11 22:38:14 UTC 2021


Module: Mesa
Branch: main
Commit: f7102bed69dd46e51ca9bf6e5630ba46ad8b6716
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7102bed69dd46e51ca9bf6e5630ba46ad8b6716

Author: Paulo Zanoni <paulo.r.zanoni at intel.com>
Date:   Mon Aug  2 13:13:13 2021 -0700

iris: don't bump the seqno for the workaround_bo

The last_seqnos list is used by iris_emit_buffer_barrier_for() and as
far as I can understand we don't emit barriers for the workaround bo,
so don't even bother doing the atomic operations required to bump the
workaround_bo seqno list.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12194>

---

 src/gallium/drivers/iris/iris_batch.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/iris/iris_batch.c b/src/gallium/drivers/iris/iris_batch.c
index ff48cfa77b1..1d94cf86a41 100644
--- a/src/gallium/drivers/iris/iris_batch.c
+++ b/src/gallium/drivers/iris/iris_batch.c
@@ -281,10 +281,9 @@ iris_use_pinned_bo(struct iris_batch *batch,
     * would introduce data dependencies between multiple batches which share
     * the buffer.
     */
-   if (bo == batch->screen->workaround_bo)
+   if (bo == batch->screen->workaround_bo) {
       writable = false;
-
-   if (access < NUM_IRIS_DOMAINS) {
+   } else if (access < NUM_IRIS_DOMAINS) {
       assert(batch->sync_region_depth);
       iris_bo_bump_seqno(bo, batch->next_seqno, access);
    }



More information about the mesa-commit mailing list